[GitHub] [spark] maropu commented on a change in pull request #29586: [SPARK-32743][SQL] Add distinct info at UnresolvedFunction toString

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #29586:
URL: https://github.com/apache/spark/pull/29586#discussion_r484595886



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -256,7 +256,10 @@ case class UnresolvedFunction(
   override lazy val resolved = false
 
   override def prettyName: String = name.unquotedString
-  override def toString: String = s"'$name(${children.mkString(", ")})"
+  override def toString: String = {
+    val distinct = if (isDistinct) "distinct " else ""
+    s"'$name($distinct${children.mkString(", ")})"

Review comment:
       Could you add tests somewhere?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org