You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "chrisdennis (via GitHub)" <gi...@apache.org> on 2025/01/28 17:33:35 UTC
[PR] [CALCITE-5136] Elevate deprecation warnings to error and handle resultant failures. [calcite-avatica]
chrisdennis opened a new pull request, #272:
URL: https://github.com/apache/calcite-avatica/pull/272
Fixes applied are:
* move `new URL(...)` to `new URI(...).toUrl()`
* move `Assert.assertThat(...)` to `MatcherAssert.assertThat(...)`
* move `ExpectedException` to `Assert.assertThrows(...)`
* in all other cases either propagate the deprecation or suppress it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Elevate deprecation warnings to error and handle resultant failures. [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#discussion_r1951406574
##########
server/src/test/java/org/apache/calcite/avatica/server/HttpServerSpnegoWithoutJaasTest.java:
##########
@@ -81,7 +81,7 @@ public class HttpServerSpnegoWithoutJaasTest {
private static boolean isKdcStarted = false;
private static boolean isHttpServerStarted = false;
- private static URL httpServerUrl;
Review Comment:
I think we should update the names in these cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Avatica build (or CI) must fail if there are deprecation warnings [calcite-avatica]
Posted by "chrisdennis (via GitHub)" <gi...@apache.org>.
chrisdennis commented on code in PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#discussion_r1959817436
##########
.idea/vcs.xml:
##########
@@ -1,27 +1,27 @@
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
- <component name="CommitMessageInspectionProfile">
- <profile version="1.0">
- <inspection_tool class="BodyLimit" enabled="true" level="WARNING" enabled_by_default="true" />
- <inspection_tool class="SubjectBodySeparation" enabled="true" level="ERROR" enabled_by_default="true" />
- <inspection_tool class="SubjectLimit" enabled="true" level="WARNING" enabled_by_default="true" />
- </profile>
- </component>
- <component name="IssueNavigationConfiguration">
- <option name="links">
- <list>
- <IssueNavigationLink>
- <option name="issueRegexp" value="[A-Z]+\-\d+" />
- <option name="linkRegexp" value="https://issues.apache.org/jira/browse/$0" />
- </IssueNavigationLink>
- <IssueNavigationLink>
- <option name="issueRegexp" value="(apache/calcite)?#(\d+)" />
- <option name="linkRegexp" value="https://github.com/apache/calcite-avatica/pull/$2" />
- </IssueNavigationLink>
- </list>
- </option>
- </component>
- <component name="VcsDirectoryMappings">
- <mapping directory="$PROJECT_DIR$" vcs="Git" />
- </component>
-</project>
+ <component name="CommitMessageInspectionProfile">
Review Comment:
Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Avatica build (or CI) must fail if there are deprecation warnings [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#issuecomment-2665900090
merged manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Elevate deprecation warnings to error and handle resultant failures. [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#discussion_r1951508374
##########
core/src/main/java/org/apache/calcite/avatica/util/Sources.java:
##########
@@ -136,8 +136,7 @@ private static URL fileToUrl(File file) {
// We need to encode path. For instance, " " should become "%20"
Review Comment:
nit:
Is this comment still needed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Avatica build (or CI) must fail if there are deprecation warnings [calcite-avatica]
Posted by "chrisdennis (via GitHub)" <gi...@apache.org>.
chrisdennis commented on code in PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#discussion_r1959810058
##########
.idea/vcs.xml:
##########
@@ -1,27 +1,27 @@
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
- <component name="CommitMessageInspectionProfile">
- <profile version="1.0">
- <inspection_tool class="BodyLimit" enabled="true" level="WARNING" enabled_by_default="true" />
- <inspection_tool class="SubjectBodySeparation" enabled="true" level="ERROR" enabled_by_default="true" />
- <inspection_tool class="SubjectLimit" enabled="true" level="WARNING" enabled_by_default="true" />
- </profile>
- </component>
- <component name="IssueNavigationConfiguration">
- <option name="links">
- <list>
- <IssueNavigationLink>
- <option name="issueRegexp" value="[A-Z]+\-\d+" />
- <option name="linkRegexp" value="https://issues.apache.org/jira/browse/$0" />
- </IssueNavigationLink>
- <IssueNavigationLink>
- <option name="issueRegexp" value="(apache/calcite)?#(\d+)" />
- <option name="linkRegexp" value="https://github.com/apache/calcite-avatica/pull/$2" />
- </IssueNavigationLink>
- </list>
- </option>
- </component>
- <component name="VcsDirectoryMappings">
- <mapping directory="$PROJECT_DIR$" vcs="Git" />
- </component>
-</project>
+ <component name="CommitMessageInspectionProfile">
Review Comment:
I did not... I guess IntelliJ got over-eager with the reformatting and I did an ill-advised `git add .`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Elevate deprecation warnings to error and handle resultant failures. [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#issuecomment-2651919045
Thank you.
Preferably yes. CALCITE-6799 already exists for the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Elevate deprecation warnings to error and handle resultant failures. [calcite-avatica]
Posted by "chrisdennis (via GitHub)" <gi...@apache.org>.
chrisdennis commented on code in PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#discussion_r1951596487
##########
core/src/main/java/org/apache/calcite/avatica/util/Sources.java:
##########
@@ -136,8 +136,7 @@ private static URL fileToUrl(File file) {
// We need to encode path. For instance, " " should become "%20"
Review Comment:
No, probably not. Removed... but closer inspection here forced me to fix something else. This branch of the code is making a very "odd" URI/URL. It's a hierarchical URI, with a relative path and a scheme. I don't know if they're illegal under the RFC... but it's certainly weird. I had to subtly tweak things here to construct one by treating it as a non-heirarchical URL (args here are: scheme, scheme-specific-part, fragment). The behavior now matches the old code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Avatica build (or CI) must fail if there are deprecation warnings [calcite-avatica]
Posted by "chrisdennis (via GitHub)" <gi...@apache.org>.
chrisdennis commented on PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#issuecomment-2656652398
@stoty something is up in CI... the force push didn't change anything: https://github.com/apache/calcite-avatica/compare/da93125c4a177717611beb1db0b51f3bf279e390..fd947c724f8a46ec45f5126adcefdeb4868e25eb
Yet somehow everything is now failing... and it looks like it's because the build resolved 4.13.x of JUnit (evidenced in all the `assertThat(...)` deprecation warnings).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Avatica build (or CI) must fail if there are deprecation warnings [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#discussion_r1959307056
##########
.idea/vcs.xml:
##########
@@ -1,27 +1,27 @@
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
- <component name="CommitMessageInspectionProfile">
- <profile version="1.0">
- <inspection_tool class="BodyLimit" enabled="true" level="WARNING" enabled_by_default="true" />
- <inspection_tool class="SubjectBodySeparation" enabled="true" level="ERROR" enabled_by_default="true" />
- <inspection_tool class="SubjectLimit" enabled="true" level="WARNING" enabled_by_default="true" />
- </profile>
- </component>
- <component name="IssueNavigationConfiguration">
- <option name="links">
- <list>
- <IssueNavigationLink>
- <option name="issueRegexp" value="[A-Z]+\-\d+" />
- <option name="linkRegexp" value="https://issues.apache.org/jira/browse/$0" />
- </IssueNavigationLink>
- <IssueNavigationLink>
- <option name="issueRegexp" value="(apache/calcite)?#(\d+)" />
- <option name="linkRegexp" value="https://github.com/apache/calcite-avatica/pull/$2" />
- </IssueNavigationLink>
- </list>
- </option>
- </component>
- <component name="VcsDirectoryMappings">
- <mapping directory="$PROJECT_DIR$" vcs="Git" />
- </component>
-</project>
+ <component name="CommitMessageInspectionProfile">
Review Comment:
Did you mean to include this @chrisdennis ?
It doesn't seem related to the deprecations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Elevate deprecation warnings to error and handle resultant failures. [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#issuecomment-2651311458
> move ExpectedException to Assert.assertThrows(...) use manual code since Guava version changes cause the code to see both 4.12 and 4.13.1 JUnit versions.
Are you sure ? We're dependency managing Junit to 4.12 , and I could not find 4.13.1 in the gradle dependecy output anywhere ?
We should upgrade to 4.13.2 anyway (in a different JIRA)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Avatica build (or CI) must fail if there are deprecation warnings [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty closed pull request #272: [CALCITE-5136] Avatica build (or CI) must fail if there are deprecation warnings
URL: https://github.com/apache/calcite-avatica/pull/272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Elevate deprecation warnings to error and handle resultant failures. [calcite-avatica]
Posted by "chrisdennis (via GitHub)" <gi...@apache.org>.
chrisdennis commented on code in PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#discussion_r1951427907
##########
server/src/test/java/org/apache/calcite/avatica/server/HttpServerSpnegoWithoutJaasTest.java:
##########
@@ -81,7 +81,7 @@ public class HttpServerSpnegoWithoutJaasTest {
private static boolean isKdcStarted = false;
private static boolean isHttpServerStarted = false;
- private static URL httpServerUrl;
Review Comment:
Pushed the rename. I *think* this was the only case where we changed the type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Elevate deprecation warnings to error and handle resultant failures. [calcite-avatica]
Posted by "chrisdennis (via GitHub)" <gi...@apache.org>.
chrisdennis commented on PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#issuecomment-2651526027
> Are you sure ? We're dependency managing Junit to 4.12 , and I could not find 4.13.1 in the gradle dependecy output anywhere ?
I could have sworn this failed locally for me... but now I can't reproduce that failure. I've pulled that change and pushed. Let's see what CI makes of it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Elevate deprecation warnings to error and handle resultant failures. [calcite-avatica]
Posted by "chrisdennis (via GitHub)" <gi...@apache.org>.
chrisdennis commented on code in PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#discussion_r1951596487
##########
core/src/main/java/org/apache/calcite/avatica/util/Sources.java:
##########
@@ -136,8 +136,7 @@ private static URL fileToUrl(File file) {
// We need to encode path. For instance, " " should become "%20"
Review Comment:
No, probably not. Removed... but closer inspection here forced me to fix something else. This branch of the code is making a very "odd" URI/URL. It's hierarchical URI, with a relative and a scheme. I don't know if they're illegal under the RFC... but it's certainly weird. I had to subtly tweak things here to construct one by treating it as a non-heirarchical URL (args here are: scheme, scheme-specific-part, fragment). The behavior now matches the old code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Elevate deprecation warnings to error and handle resultant failures. [calcite-avatica]
Posted by "chrisdennis (via GitHub)" <gi...@apache.org>.
chrisdennis commented on PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#issuecomment-2651803020
FYI: I pounded on the test that failed on macOS locally and see the following pattern:
```
Failure Statistics
49976 : connection refused
24 : connection reset
```
The existing code doesn't account for "connection reset". I have a fix for this... does it need a JIRA issue, and a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Avatica build (or CI) must fail if there are deprecation warnings [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#discussion_r1959307056
##########
.idea/vcs.xml:
##########
@@ -1,27 +1,27 @@
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
- <component name="CommitMessageInspectionProfile">
- <profile version="1.0">
- <inspection_tool class="BodyLimit" enabled="true" level="WARNING" enabled_by_default="true" />
- <inspection_tool class="SubjectBodySeparation" enabled="true" level="ERROR" enabled_by_default="true" />
- <inspection_tool class="SubjectLimit" enabled="true" level="WARNING" enabled_by_default="true" />
- </profile>
- </component>
- <component name="IssueNavigationConfiguration">
- <option name="links">
- <list>
- <IssueNavigationLink>
- <option name="issueRegexp" value="[A-Z]+\-\d+" />
- <option name="linkRegexp" value="https://issues.apache.org/jira/browse/$0" />
- </IssueNavigationLink>
- <IssueNavigationLink>
- <option name="issueRegexp" value="(apache/calcite)?#(\d+)" />
- <option name="linkRegexp" value="https://github.com/apache/calcite-avatica/pull/$2" />
- </IssueNavigationLink>
- </list>
- </option>
- </component>
- <component name="VcsDirectoryMappings">
- <mapping directory="$PROJECT_DIR$" vcs="Git" />
- </component>
-</project>
+ <component name="CommitMessageInspectionProfile">
Review Comment:
Did you mean to include this @chrisdennis ?
It doesn't seem related to the depracations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Avatica build (or CI) must fail if there are deprecation warnings [calcite-avatica]
Posted by "chrisdennis (via GitHub)" <gi...@apache.org>.
chrisdennis commented on PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#issuecomment-2656629634
> One minor detail though, per our contribution [guidelines](https://calcite.apache.org/develop/#contributing), commit messages should not end with a period; apart from that I think generally we tend to use as final commit message the Jira title, i.e. `[CALCITE-5136] Avatica build (or CI) must fail if there are deprecation warnings` in this case.
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-5136] Elevate deprecation warnings to error and handle resultant failures. [calcite-avatica]
Posted by "rubenada (via GitHub)" <gi...@apache.org>.
rubenada commented on PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#issuecomment-2655900967
This PR looks in a good shape, shall we move on?
One minor detail though, per our contribution [guidelines](https://calcite.apache.org/develop/#contributing), commit messages should not end with a period; apart from that I think generally we tend to use as final commit message the Jira title, i.e. `[CALCITE-5136] Avatica build (or CI) must fail if there are deprecation warnings` in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org