[GitHub] [superset] xinjingqing commented on pull request #17278: fix: The filter mapping configuration can not be saved in V1.2.0 +

[GitBox <gi...@apache.org>]

xinjingqing commented on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-1012118164


   ok,i get it, thanks
   
   
   Best Regards
   
   
   
   
   On 01/13/2022 08:25，Joey ***@***.***> wrote：
   
   @yeoji commented on this pull request.
   
   In superset-frontend/src/dashboard/actions/dashboardInfo.ts:
   
   > @@ -60,10 +64,12 @@ export const setChartConfiguration = (
      });
    
      try {
   +    const filterCondition = JSON.parse(String(filterscopes));
   
   
   Hey @xinjingqing, I've come across this issue too and found your fix.
   
   Just wanted to note that this line breaks the saving of cross filter scoping since filterscopes is undefined (called from CrossFilterScopingModal.tsx), so it's probably necessary to check this parameter before attempting to JSON.parse it.
   
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android.
   You are receiving this because you were mentioned.Message ID: ***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org