You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2014/03/25 20:09:07 UTC
Re: Review Request 19006: Moved slave disconnection code out of
Master::exited() into new disconnect(Slave).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19006/
-----------------------------------------------------------
(Updated March 25, 2014, 12:09 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Summary/Description updates
Summary (updated)
-----------------
Moved slave disconnection code out of Master::exited() into new disconnect(Slave).
Bugs: MESOS-804
https://issues.apache.org/jira/browse/MESOS-804
Repository: mesos-git
Description (updated)
-------
Moved code to disconnect a checkpointing slave out of Master::exited() and into a new disconnect(Slave), to be re-used by slave authentication code.
Also renamed deactivateSlave() to shutdownSlave(), since it actually sends a ShutdownMessage and calls removeSlave(). This avoids confusion with deactivateFramework, which is more analagous to disconnect(Slave).
Diffs
-----
src/master/master.hpp a8ed5ec
src/master/master.cpp a951a7a
Diff: https://reviews.apache.org/r/19006/diff/
Testing
-------
make check
Thanks,
Adam B
Re: Review Request 19006: Moved slave disconnection code out of
Master::exited() into new disconnect(Slave).
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19006/#review38999
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19006]
All tests passed.
- Mesos ReviewBot
On March 27, 2014, 4:41 a.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19006/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 4:41 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-804
> https://issues.apache.org/jira/browse/MESOS-804
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Moved code to disconnect a checkpointing slave out of Master::exited() and into a new disconnect(Slave), to be re-used by slave authentication code.
> Also renamed deactivateSlave() to shutdownSlave(), since it actually sends a ShutdownMessage and calls removeSlave(). This avoids confusion with deactivateFramework, which is more analagous to disconnect(Slave).
>
>
> Diffs
> -----
>
> src/master/master.hpp b6b9983
> src/master/master.cpp 5d0ddb0
>
> Diff: https://reviews.apache.org/r/19006/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19006: Moved slave disconnection code out of
Master::exited() into new disconnect(Slave).
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On April 2, 2014, 1:29 a.m., Benjamin Hindman wrote:
> > Ship It!
This change is independent of the naming in 'Slaves', so let's get it committed and follow up with another review. Thanks Adam.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19006/#review39227
-----------------------------------------------------------
On March 27, 2014, 4:41 a.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19006/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 4:41 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-804
> https://issues.apache.org/jira/browse/MESOS-804
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Moved code to disconnect a checkpointing slave out of Master::exited() and into a new disconnect(Slave), to be re-used by slave authentication code.
> Also renamed deactivateSlave() to shutdownSlave(), since it actually sends a ShutdownMessage and calls removeSlave(). This avoids confusion with deactivateFramework, which is more analagous to disconnect(Slave).
>
>
> Diffs
> -----
>
> src/master/master.hpp b6b9983
> src/master/master.cpp 5d0ddb0
>
> Diff: https://reviews.apache.org/r/19006/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19006: Moved slave disconnection code out of
Master::exited() into new disconnect(Slave).
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19006/#review39227
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 27, 2014, 4:41 a.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19006/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 4:41 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-804
> https://issues.apache.org/jira/browse/MESOS-804
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Moved code to disconnect a checkpointing slave out of Master::exited() and into a new disconnect(Slave), to be re-used by slave authentication code.
> Also renamed deactivateSlave() to shutdownSlave(), since it actually sends a ShutdownMessage and calls removeSlave(). This avoids confusion with deactivateFramework, which is more analagous to disconnect(Slave).
>
>
> Diffs
> -----
>
> src/master/master.hpp b6b9983
> src/master/master.cpp 5d0ddb0
>
> Diff: https://reviews.apache.org/r/19006/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19006: Moved slave disconnection code out of
Master::exited() into new disconnect(Slave).
Posted by Adam B <ad...@mesosphere.io>.
> On April 1, 2014, 4:57 p.m., Benjamin Hindman wrote:
> > src/master/master.hpp, line 390
> > <https://reviews.apache.org/r/19006/diff/4/?file=537795#file537795line390>
> >
> > What about the use of activated/deactivated here? Can we have 'connected', 'disconnected', and 'removed' where 'removed' will eventually be removed (no pun intended) once the registrar is fully in place?
Filed new JIRA MESOS-1188 to "Rename slaves/frameworks.activated/deactivated". We can discuss naming suggestions there.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19006/#review39219
-----------------------------------------------------------
On March 26, 2014, 9:41 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19006/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 9:41 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-804
> https://issues.apache.org/jira/browse/MESOS-804
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Moved code to disconnect a checkpointing slave out of Master::exited() and into a new disconnect(Slave), to be re-used by slave authentication code.
> Also renamed deactivateSlave() to shutdownSlave(), since it actually sends a ShutdownMessage and calls removeSlave(). This avoids confusion with deactivateFramework, which is more analagous to disconnect(Slave).
>
>
> Diffs
> -----
>
> src/master/master.hpp b6b9983
> src/master/master.cpp 5d0ddb0
>
> Diff: https://reviews.apache.org/r/19006/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19006: Moved slave disconnection code out of
Master::exited() into new disconnect(Slave).
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19006/#review39219
-----------------------------------------------------------
src/master/master.hpp
<https://reviews.apache.org/r/19006/#comment71584>
What about the use of activated/deactivated here? Can we have 'connected', 'disconnected', and 'removed' where 'removed' will eventually be removed (no pun intended) once the registrar is fully in place?
- Benjamin Hindman
On March 27, 2014, 4:41 a.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19006/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 4:41 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-804
> https://issues.apache.org/jira/browse/MESOS-804
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Moved code to disconnect a checkpointing slave out of Master::exited() and into a new disconnect(Slave), to be re-used by slave authentication code.
> Also renamed deactivateSlave() to shutdownSlave(), since it actually sends a ShutdownMessage and calls removeSlave(). This avoids confusion with deactivateFramework, which is more analagous to disconnect(Slave).
>
>
> Diffs
> -----
>
> src/master/master.hpp b6b9983
> src/master/master.cpp 5d0ddb0
>
> Diff: https://reviews.apache.org/r/19006/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19006: Moved slave disconnection code out of
Master::exited() into new disconnect(Slave).
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19006/
-----------------------------------------------------------
(Updated March 26, 2014, 9:41 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Rebased again, to prepare for rebasing dependent review 18381 (slave authentication). Please review when you can, bmahler.
Bugs: MESOS-804
https://issues.apache.org/jira/browse/MESOS-804
Repository: mesos-git
Description
-------
Moved code to disconnect a checkpointing slave out of Master::exited() and into a new disconnect(Slave), to be re-used by slave authentication code.
Also renamed deactivateSlave() to shutdownSlave(), since it actually sends a ShutdownMessage and calls removeSlave(). This avoids confusion with deactivateFramework, which is more analagous to disconnect(Slave).
Diffs (updated)
-----
src/master/master.hpp b6b9983
src/master/master.cpp 5d0ddb0
Diff: https://reviews.apache.org/r/19006/diff/
Testing
-------
make check
Thanks,
Adam B