You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/11 09:24:46 UTC

[GitHub] [incubator-nuttx] davids5 removed a comment on pull request #1747: sched: Rename note_add to sched_note_add

davids5 removed a comment on pull request #1747:
URL: https://github.com/apache/incubator-nuttx/pull/1747#issuecomment-690927791


   @xiaoxiang781216 - This is foolish,  fixing an API is completely different then hijacking it. 
   
   In the case you are referencing, the the fix is to change the type. - The compiler tells the user what to fix - Done. We do this all the time. 
   
   In this situation it can not be fixed externally. (it can be but using `weak`, or `wrapping` seem almost as foolish as this discussion) 
   You are **hijacking** a the functions names of EXTERNAL call outs. What do you expect, the remedy to be?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org