You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Krishna Sadasivam <ks...@brocade.com> on 2012/08/09 01:31:29 UTC

Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6492/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

This is the patch for adding Brocade plugin to enable Brocade LBs in CloudStack. The plugin can support Lb service in advanced zone networking.
Lb services: 
*Protocols: TCP/UDP
*Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin, weighted round robin static, enhanced weighted, responsetime
*Sticky Session persistence using sticky port


Diffs
-----

  build/build-cloud-plugins.xml a7a1f39 
  build/build-cloud.xml b4d120f 
  build/developer.xml d52b682 
  client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-CREATION 
  client/tomcatconf/components.xml.in da7617d 
  deps/.classpath 1376b4f 
  deps/cloud-BrocadeService.jar PRE-CREATION 
  plugins/network-elements/brocade/.classpath PRE-CREATION 
  plugins/network-elements/brocade/.project PRE-CREATION 
  plugins/network-elements/brocade/build.xml PRE-CREATION 
  plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.java PRE-CREATION 
  plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalancerCmd.java PRE-CREATION 
  plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java PRE-CREATION 
  plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNetworksCmd.java PRE-CREATION 
  plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCmd.java PRE-CREATION 
  plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java PRE-CREATION 
  plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java PRE-CREATION 
  plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerResponse.java PRE-CREATION 
  plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java PRE-CREATION 
  plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElementService.java PRE-CREATION 
  plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java PRE-CREATION 
  plugins/network-elements/brocade/test/com/cloud/network/element/Base64.java PRE-CREATION 
  plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/6492/diff/


Testing
-------

Unit tests, Rest API calls from Rest client code 


Thanks,

Krishna Sadasivam


Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Vijay Venkatachalam <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6492/#review10565
-----------------------------------------------------------



deps/.classpath
<https://reviews.apache.org/r/6492/#comment22666>

    Minor Comment: could name it in lower-case to be consistent with the other jars.



plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java
<https://reviews.apache.org/r/6492/#comment22668>

    You should use EVENT_EXTERNAL_LB_DEVICE_DELETE. I see how you could have ended up in this error. Current external loadbalancer's delete cmds also return the wrong delete event type.



plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java
<https://reviews.apache.org/r/6492/#comment22669>

    responseObject is wrong. It should be SuccessResponse?



plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java
<https://reviews.apache.org/r/6492/#comment22672>

    Weighted round-robin is present in almost every lodadbalaner. Better to support this in the core rather than in a plug-in. May be in assignToLoadBalancerRule extra-parameters have to be added for weights.



plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java
<https://reviews.apache.org/r/6492/#comment22598>

    The weights for a Vm are not getting stored in the db. How will the user know the weight set?
    
    PS:
    I am not sure on how are VOs written for plugins
    
    



plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java
<https://reviews.apache.org/r/6492/#comment22670>

    No null check is required for mandatory parameters.



plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java
<https://reviews.apache.org/r/6492/#comment22671>

    A Vm can participate in many networks you might want to pick the right IP, you can use the following function for finding the right one
    NicDao.findByInstanceIdAndNetworkIdIncludingRemoved(networkId, vmId);
    


- Vijay Venkatachalam


On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6492/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 11:31 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> This is the patch for adding Brocade plugin to enable Brocade LBs in CloudStack. The plugin can support Lb service in advanced zone networking.
> Lb services: 
> *Protocols: TCP/UDP
> *Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin, weighted round robin static, enhanced weighted, responsetime
> *Sticky Session persistence using sticky port
> 
> 
> Diffs
> -----
> 
>   build/build-cloud-plugins.xml a7a1f39 
>   build/build-cloud.xml b4d120f 
>   build/developer.xml d52b682 
>   client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-CREATION 
>   client/tomcatconf/components.xml.in da7617d 
>   deps/.classpath 1376b4f 
>   deps/cloud-BrocadeService.jar PRE-CREATION 
>   plugins/network-elements/brocade/.classpath PRE-CREATION 
>   plugins/network-elements/brocade/.project PRE-CREATION 
>   plugins/network-elements/brocade/build.xml PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNetworksCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerResponse.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElementService.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java PRE-CREATION 
>   plugins/network-elements/brocade/test/com/cloud/network/element/Base64.java PRE-CREATION 
>   plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6492/diff/
> 
> 
> Testing
> -------
> 
> Unit tests, Rest API calls from Rest client code 
> 
> 
> Thanks,
> 
> Krishna Sadasivam
> 
>


RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Krishna Sadasivam <ks...@Brocade.com>.
Hi Ewan,
    I have asked the concerned people in Brocade to respond to the licensing issues. I will get back to you soon.

Thanks,
Krishna

-----Original Message-----
From: Ewan Mellor [mailto:Ewan.Mellor@eu.citrix.com] 
Sent: Thursday, August 09, 2012 4:29 PM
To: cloudstack-dev@incubator.apache.org
Subject: RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Hi Krishna,

First of all, thanks for the patch!  It's great to see Brocade getting involved in CloudStack, and I hope that you will be able to do more in the future too.

I don't know if you know this, but we're trying to get a CloudStack 4.0 release together in the next month.  The deadline for feature freeze is rapidly approaching, so for your patch to get in, we'd have to get these license issues resolved very soon (like, in a day or two).

If there is going to be any delay figuring out the licensing on cloud-BrocadeService.jar, would it be a problem if this patch didn't get into CloudStack 4.0?  If that's OK, it would go immediately on the list for 4.1 instead.  That would give you time to sort out what you want to do here.

As general guidance:

The easiest thing to do is to license your code under the Apache license, or a compatible one such as BSD.  This will mean that we can have the default CloudStack build include support for your LBs, which is obviously a big win.

The Apache Foundation won't allow code that requires proprietary libraries in the default configuration, so if you can't do this, then the feature would have to be off by default.  This isn't the end of the world, but it means that users would have to recompile CloudStack from source to enable your software.  This would be the case if that jar is only available to Brocade customers or otherwise not freely distributable.  We're going to have to turn off NetApp support in the default build for this reason, to give you an example.

Please let me know what you're planning to do at this point, so that we can finalize the upcoming release.

Thanks,

Ewan.

> -----Original Message-----
> From: Krishna Sadasivam [mailto:ksadasiv@Brocade.com]
> Sent: Wednesday, August 08, 2012 5:30 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Review Request: Plugin for enabling Brocade as external 
> load balancing service provider in CloudStack
> 
> I am not sure about the license. This is the first time I am 
> submitting code to open source. Let me get back to you on the license 
> and the link for the jar.
> 
> Thanks,
> Krishna
> 
> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Wednesday, August 08, 2012 5:16 PM
> To: Krishna Sadasivam
> Cc: cloudstack-dev@incubator.apache.org
> Subject: Re: Review Request: Plugin for enabling Brocade as external 
> load balancing service provider in CloudStack
> 
> What license is it released under?
> We need to likely set it up so that the jar can be downloaded 
> automagically, but isn't included in the repo by default.
> If we were to set ant, ivy, gradle, or maven to do this in an 
> automated fashion, where would we acquire the jar from?
> 
> --David
> 
> On Wed, Aug 8, 2012 at 8:12 PM, Krishna Sadasivam 
> <ks...@brocade.com> wrote:
> > Hi David,
> >   cloud-BrocadeService.jar enables communication with Brocade load
> balancers. It won't be under Apache License. Can I send the jar as an 
> attachment for now?
> >
> > Krishna
> >
> > -----Original Message-----
> > From: David Nalley [mailto:noreply@reviews.apache.org] On Behalf Of 
> > David Nalley
> > Sent: Wednesday, August 08, 2012 5:01 PM
> > To: cloudstack; David Nalley; Krishna Sadasivam
> > Subject: Re: Review Request: Plugin for enabling Brocade as external 
> > load balancing service provider in CloudStack
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/6492/#review10050
> > -----------------------------------------------------------
> >
> >
> > Where does this file come from: deps/cloud-BrocadeService.jar
> >
> > What is it licensed under?
> > Link?
> >
> > --David
> >
> > - David Nalley
> >
> >
> > On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote:
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/6492/
> >> -----------------------------------------------------------
> >>
> >> (Updated Aug. 8, 2012, 11:31 p.m.)
> >>
> >>
> >> Review request for cloudstack.
> >>
> >>
> >> Description
> >> -------
> >>
> >> This is the patch for adding Brocade plugin to enable Brocade LBs 
> >> in
> CloudStack. The plugin can support Lb service in advanced zone 
> networking.
> >> Lb services:
> >> *Protocols: TCP/UDP
> >> *Lb algorithms: roundrobin, leastconn, weighted, 
> >> weightedroundrobin, weighted round robin static, enhanced weighted, 
> >> responsetime *Sticky Session persistence using sticky port
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>   build/build-cloud-plugins.xml a7a1f39
> >>   build/build-cloud.xml b4d120f
> >>   build/developer.xml d52b682
> >>   client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-
> CREATION
> >>   client/tomcatconf/components.xml.in da7617d
> >>   deps/.classpath 1376b4f
> >>   deps/cloud-BrocadeService.jar PRE-CREATION
> >>   plugins/network-elements/brocade/.classpath PRE-CREATION
> >>   plugins/network-elements/brocade/.project PRE-CREATION
> >>   plugins/network-elements/brocade/build.xml PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.
> j
> ava PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalanc
> e
> rCmd.java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerC
> m
> d.java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNet
> w
> orksCmd.java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCm
> d
> .java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java
> PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorC
> m
> d.java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerRespons
> e
> .java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/network/element/BrocadeElement.java 
> PRE- CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElem
> e
> ntService.java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.jav
> a
> PRE-CREATION
> >>
> >> plugins/network-
> elements/brocade/test/com/cloud/network/element/Base6
> >> 4.java PRE-CREATION
> >>
> >> plugins/network-
> elements/brocade/test/com/cloud/network/element/Broca
> >> d
> >> ePluginTest.java PRE-CREATION
> >>
> >> Diff: https://reviews.apache.org/r/6492/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >> Unit tests, Rest API calls from Rest client code
> >>
> >>
> >> Thanks,
> >>
> >> Krishna Sadasivam
> >>
> >>
> >

RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Ewan Mellor <Ew...@eu.citrix.com>.
Hi Krishna,

First of all, thanks for the patch!  It's great to see Brocade getting involved in CloudStack, and I hope that you will be able to do more in the future too.

I don't know if you know this, but we're trying to get a CloudStack 4.0 release together in the next month.  The deadline for feature freeze is rapidly approaching, so for your patch to get in, we'd have to get these license issues resolved very soon (like, in a day or two).

If there is going to be any delay figuring out the licensing on cloud-BrocadeService.jar, would it be a problem if this patch didn't get into CloudStack 4.0?  If that's OK, it would go immediately on the list for 4.1 instead.  That would give you time to sort out what you want to do here.

As general guidance:

The easiest thing to do is to license your code under the Apache license, or a compatible one such as BSD.  This will mean that we can have the default CloudStack build include support for your LBs, which is obviously a big win.

The Apache Foundation won't allow code that requires proprietary libraries in the default configuration, so if you can't do this, then the feature would have to be off by default.  This isn't the end of the world, but it means that users would have to recompile CloudStack from source to enable your software.  This would be the case if that jar is only available to Brocade customers or otherwise not freely distributable.  We're going to have to turn off NetApp support in the default build for this reason, to give you an example.

Please let me know what you're planning to do at this point, so that we can finalize the upcoming release.

Thanks,

Ewan.

> -----Original Message-----
> From: Krishna Sadasivam [mailto:ksadasiv@Brocade.com]
> Sent: Wednesday, August 08, 2012 5:30 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Review Request: Plugin for enabling Brocade as external
> load balancing service provider in CloudStack
> 
> I am not sure about the license. This is the first time I am submitting
> code to open source. Let me get back to you on the license and the link
> for the jar.
> 
> Thanks,
> Krishna
> 
> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Wednesday, August 08, 2012 5:16 PM
> To: Krishna Sadasivam
> Cc: cloudstack-dev@incubator.apache.org
> Subject: Re: Review Request: Plugin for enabling Brocade as external
> load balancing service provider in CloudStack
> 
> What license is it released under?
> We need to likely set it up so that the jar can be downloaded
> automagically, but isn't included in the repo by default.
> If we were to set ant, ivy, gradle, or maven to do this in an automated
> fashion, where would we acquire the jar from?
> 
> --David
> 
> On Wed, Aug 8, 2012 at 8:12 PM, Krishna Sadasivam
> <ks...@brocade.com> wrote:
> > Hi David,
> >   cloud-BrocadeService.jar enables communication with Brocade load
> balancers. It won't be under Apache License. Can I send the jar as an
> attachment for now?
> >
> > Krishna
> >
> > -----Original Message-----
> > From: David Nalley [mailto:noreply@reviews.apache.org] On Behalf Of
> > David Nalley
> > Sent: Wednesday, August 08, 2012 5:01 PM
> > To: cloudstack; David Nalley; Krishna Sadasivam
> > Subject: Re: Review Request: Plugin for enabling Brocade as external
> > load balancing service provider in CloudStack
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/6492/#review10050
> > -----------------------------------------------------------
> >
> >
> > Where does this file come from: deps/cloud-BrocadeService.jar
> >
> > What is it licensed under?
> > Link?
> >
> > --David
> >
> > - David Nalley
> >
> >
> > On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote:
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/6492/
> >> -----------------------------------------------------------
> >>
> >> (Updated Aug. 8, 2012, 11:31 p.m.)
> >>
> >>
> >> Review request for cloudstack.
> >>
> >>
> >> Description
> >> -------
> >>
> >> This is the patch for adding Brocade plugin to enable Brocade LBs in
> CloudStack. The plugin can support Lb service in advanced zone
> networking.
> >> Lb services:
> >> *Protocols: TCP/UDP
> >> *Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin,
> >> weighted round robin static, enhanced weighted, responsetime *Sticky
> >> Session persistence using sticky port
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>   build/build-cloud-plugins.xml a7a1f39
> >>   build/build-cloud.xml b4d120f
> >>   build/developer.xml d52b682
> >>   client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-
> CREATION
> >>   client/tomcatconf/components.xml.in da7617d
> >>   deps/.classpath 1376b4f
> >>   deps/cloud-BrocadeService.jar PRE-CREATION
> >>   plugins/network-elements/brocade/.classpath PRE-CREATION
> >>   plugins/network-elements/brocade/.project PRE-CREATION
> >>   plugins/network-elements/brocade/build.xml PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.j
> ava PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalance
> rCmd.java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCm
> d.java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNetw
> orksCmd.java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCmd
> .java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java
> PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCm
> d.java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerResponse
> .java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/network/element/BrocadeElement.java PRE-
> CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerEleme
> ntService.java PRE-CREATION
> >>   plugins/network-
> elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java
> PRE-CREATION
> >>
> >> plugins/network-
> elements/brocade/test/com/cloud/network/element/Base6
> >> 4.java PRE-CREATION
> >>
> >> plugins/network-
> elements/brocade/test/com/cloud/network/element/Broca
> >> d
> >> ePluginTest.java PRE-CREATION
> >>
> >> Diff: https://reviews.apache.org/r/6492/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >> Unit tests, Rest API calls from Rest client code
> >>
> >>
> >> Thanks,
> >>
> >> Krishna Sadasivam
> >>
> >>
> >

Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by David Nalley <da...@gnsa.us>.
Thanks Krishna,

If we can help, don't hesitate to ask.

--David

On Wed, Aug 8, 2012 at 8:29 PM, Krishna Sadasivam <ks...@brocade.com> wrote:
> I am not sure about the license. This is the first time I am submitting code to open source. Let me get back to you on the license and the link for the jar.
>
> Thanks,
> Krishna
>
> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Wednesday, August 08, 2012 5:16 PM
> To: Krishna Sadasivam
> Cc: cloudstack-dev@incubator.apache.org
> Subject: Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack
>
> What license is it released under?
> We need to likely set it up so that the jar can be downloaded automagically, but isn't included in the repo by default.
> If we were to set ant, ivy, gradle, or maven to do this in an automated fashion, where would we acquire the jar from?
>
> --David
>
> On Wed, Aug 8, 2012 at 8:12 PM, Krishna Sadasivam <ks...@brocade.com> wrote:
>> Hi David,
>>   cloud-BrocadeService.jar enables communication with Brocade load balancers. It won't be under Apache License. Can I send the jar as an attachment for now?
>>
>> Krishna
>>
>> -----Original Message-----
>> From: David Nalley [mailto:noreply@reviews.apache.org] On Behalf Of
>> David Nalley
>> Sent: Wednesday, August 08, 2012 5:01 PM
>> To: cloudstack; David Nalley; Krishna Sadasivam
>> Subject: Re: Review Request: Plugin for enabling Brocade as external
>> load balancing service provider in CloudStack
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/6492/#review10050
>> -----------------------------------------------------------
>>
>>
>> Where does this file come from: deps/cloud-BrocadeService.jar
>>
>> What is it licensed under?
>> Link?
>>
>> --David
>>
>> - David Nalley
>>
>>
>> On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote:
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/6492/
>>> -----------------------------------------------------------
>>>
>>> (Updated Aug. 8, 2012, 11:31 p.m.)
>>>
>>>
>>> Review request for cloudstack.
>>>
>>>
>>> Description
>>> -------
>>>
>>> This is the patch for adding Brocade plugin to enable Brocade LBs in CloudStack. The plugin can support Lb service in advanced zone networking.
>>> Lb services:
>>> *Protocols: TCP/UDP
>>> *Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin,
>>> weighted round robin static, enhanced weighted, responsetime *Sticky
>>> Session persistence using sticky port
>>>
>>>
>>> Diffs
>>> -----
>>>
>>>   build/build-cloud-plugins.xml a7a1f39
>>>   build/build-cloud.xml b4d120f
>>>   build/developer.xml d52b682
>>>   client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-CREATION
>>>   client/tomcatconf/components.xml.in da7617d
>>>   deps/.classpath 1376b4f
>>>   deps/cloud-BrocadeService.jar PRE-CREATION
>>>   plugins/network-elements/brocade/.classpath PRE-CREATION
>>>   plugins/network-elements/brocade/.project PRE-CREATION
>>>   plugins/network-elements/brocade/build.xml PRE-CREATION
>>>   plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.java PRE-CREATION
>>>   plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalancerCmd.java PRE-CREATION
>>>   plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java PRE-CREATION
>>>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNetworksCmd.java PRE-CREATION
>>>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCmd.java PRE-CREATION
>>>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java PRE-CREATION
>>>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java PRE-CREATION
>>>   plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerResponse.java PRE-CREATION
>>>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java PRE-CREATION
>>>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElementService.java PRE-CREATION
>>>   plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java PRE-CREATION
>>>
>>> plugins/network-elements/brocade/test/com/cloud/network/element/Base6
>>> 4.java PRE-CREATION
>>>
>>> plugins/network-elements/brocade/test/com/cloud/network/element/Broca
>>> d
>>> ePluginTest.java PRE-CREATION
>>>
>>> Diff: https://reviews.apache.org/r/6492/diff/
>>>
>>>
>>> Testing
>>> -------
>>>
>>> Unit tests, Rest API calls from Rest client code
>>>
>>>
>>> Thanks,
>>>
>>> Krishna Sadasivam
>>>
>>>
>>

RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Krishna Sadasivam <ks...@Brocade.com>.
I am not sure about the license. This is the first time I am submitting code to open source. Let me get back to you on the license and the link for the jar.

Thanks,
Krishna

-----Original Message-----
From: David Nalley [mailto:david@gnsa.us] 
Sent: Wednesday, August 08, 2012 5:16 PM
To: Krishna Sadasivam
Cc: cloudstack-dev@incubator.apache.org
Subject: Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

What license is it released under?
We need to likely set it up so that the jar can be downloaded automagically, but isn't included in the repo by default.
If we were to set ant, ivy, gradle, or maven to do this in an automated fashion, where would we acquire the jar from?

--David

On Wed, Aug 8, 2012 at 8:12 PM, Krishna Sadasivam <ks...@brocade.com> wrote:
> Hi David,
>   cloud-BrocadeService.jar enables communication with Brocade load balancers. It won't be under Apache License. Can I send the jar as an attachment for now?
>
> Krishna
>
> -----Original Message-----
> From: David Nalley [mailto:noreply@reviews.apache.org] On Behalf Of 
> David Nalley
> Sent: Wednesday, August 08, 2012 5:01 PM
> To: cloudstack; David Nalley; Krishna Sadasivam
> Subject: Re: Review Request: Plugin for enabling Brocade as external 
> load balancing service provider in CloudStack
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6492/#review10050
> -----------------------------------------------------------
>
>
> Where does this file come from: deps/cloud-BrocadeService.jar
>
> What is it licensed under?
> Link?
>
> --David
>
> - David Nalley
>
>
> On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/6492/
>> -----------------------------------------------------------
>>
>> (Updated Aug. 8, 2012, 11:31 p.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Description
>> -------
>>
>> This is the patch for adding Brocade plugin to enable Brocade LBs in CloudStack. The plugin can support Lb service in advanced zone networking.
>> Lb services:
>> *Protocols: TCP/UDP
>> *Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin, 
>> weighted round robin static, enhanced weighted, responsetime *Sticky 
>> Session persistence using sticky port
>>
>>
>> Diffs
>> -----
>>
>>   build/build-cloud-plugins.xml a7a1f39
>>   build/build-cloud.xml b4d120f
>>   build/developer.xml d52b682
>>   client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-CREATION
>>   client/tomcatconf/components.xml.in da7617d
>>   deps/.classpath 1376b4f
>>   deps/cloud-BrocadeService.jar PRE-CREATION
>>   plugins/network-elements/brocade/.classpath PRE-CREATION
>>   plugins/network-elements/brocade/.project PRE-CREATION
>>   plugins/network-elements/brocade/build.xml PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalancerCmd.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNetworksCmd.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCmd.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerResponse.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElementService.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java PRE-CREATION
>>   
>> plugins/network-elements/brocade/test/com/cloud/network/element/Base6
>> 4.java PRE-CREATION
>>
>> plugins/network-elements/brocade/test/com/cloud/network/element/Broca
>> d
>> ePluginTest.java PRE-CREATION
>>
>> Diff: https://reviews.apache.org/r/6492/diff/
>>
>>
>> Testing
>> -------
>>
>> Unit tests, Rest API calls from Rest client code
>>
>>
>> Thanks,
>>
>> Krishna Sadasivam
>>
>>
>

Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by David Nalley <da...@gnsa.us>.
What license is it released under?
We need to likely set it up so that the jar can be downloaded
automagically, but isn't included in the repo by default.
If we were to set ant, ivy, gradle, or maven to do this in an
automated fashion, where would we acquire the jar from?

--David

On Wed, Aug 8, 2012 at 8:12 PM, Krishna Sadasivam <ks...@brocade.com> wrote:
> Hi David,
>   cloud-BrocadeService.jar enables communication with Brocade load balancers. It won’t be under Apache License. Can I send the jar as an attachment for now?
>
> Krishna
>
> -----Original Message-----
> From: David Nalley [mailto:noreply@reviews.apache.org] On Behalf Of David Nalley
> Sent: Wednesday, August 08, 2012 5:01 PM
> To: cloudstack; David Nalley; Krishna Sadasivam
> Subject: Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6492/#review10050
> -----------------------------------------------------------
>
>
> Where does this file come from: deps/cloud-BrocadeService.jar
>
> What is it licensed under?
> Link?
>
> --David
>
> - David Nalley
>
>
> On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/6492/
>> -----------------------------------------------------------
>>
>> (Updated Aug. 8, 2012, 11:31 p.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Description
>> -------
>>
>> This is the patch for adding Brocade plugin to enable Brocade LBs in CloudStack. The plugin can support Lb service in advanced zone networking.
>> Lb services:
>> *Protocols: TCP/UDP
>> *Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin,
>> weighted round robin static, enhanced weighted, responsetime *Sticky
>> Session persistence using sticky port
>>
>>
>> Diffs
>> -----
>>
>>   build/build-cloud-plugins.xml a7a1f39
>>   build/build-cloud.xml b4d120f
>>   build/developer.xml d52b682
>>   client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-CREATION
>>   client/tomcatconf/components.xml.in da7617d
>>   deps/.classpath 1376b4f
>>   deps/cloud-BrocadeService.jar PRE-CREATION
>>   plugins/network-elements/brocade/.classpath PRE-CREATION
>>   plugins/network-elements/brocade/.project PRE-CREATION
>>   plugins/network-elements/brocade/build.xml PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalancerCmd.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNetworksCmd.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCmd.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerResponse.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElementService.java PRE-CREATION
>>   plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java PRE-CREATION
>>   plugins/network-elements/brocade/test/com/cloud/network/element/Base64.java PRE-CREATION
>>
>> plugins/network-elements/brocade/test/com/cloud/network/element/Brocad
>> ePluginTest.java PRE-CREATION
>>
>> Diff: https://reviews.apache.org/r/6492/diff/
>>
>>
>> Testing
>> -------
>>
>> Unit tests, Rest API calls from Rest client code
>>
>>
>> Thanks,
>>
>> Krishna Sadasivam
>>
>>
>

RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Krishna Sadasivam <ks...@Brocade.com>.
Hi David,
  cloud-BrocadeService.jar enables communication with Brocade load balancers. It won’t be under Apache License. Can I send the jar as an attachment for now?

Krishna

-----Original Message-----
From: David Nalley [mailto:noreply@reviews.apache.org] On Behalf Of David Nalley
Sent: Wednesday, August 08, 2012 5:01 PM
To: cloudstack; David Nalley; Krishna Sadasivam
Subject: Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6492/#review10050
-----------------------------------------------------------


Where does this file come from: deps/cloud-BrocadeService.jar

What is it licensed under? 
Link? 

--David

- David Nalley


On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6492/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 11:31 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> This is the patch for adding Brocade plugin to enable Brocade LBs in CloudStack. The plugin can support Lb service in advanced zone networking.
> Lb services: 
> *Protocols: TCP/UDP
> *Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin, 
> weighted round robin static, enhanced weighted, responsetime *Sticky 
> Session persistence using sticky port
> 
> 
> Diffs
> -----
> 
>   build/build-cloud-plugins.xml a7a1f39 
>   build/build-cloud.xml b4d120f 
>   build/developer.xml d52b682 
>   client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-CREATION 
>   client/tomcatconf/components.xml.in da7617d 
>   deps/.classpath 1376b4f 
>   deps/cloud-BrocadeService.jar PRE-CREATION 
>   plugins/network-elements/brocade/.classpath PRE-CREATION 
>   plugins/network-elements/brocade/.project PRE-CREATION 
>   plugins/network-elements/brocade/build.xml PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNetworksCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerResponse.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElementService.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java PRE-CREATION 
>   plugins/network-elements/brocade/test/com/cloud/network/element/Base64.java PRE-CREATION 
>   
> plugins/network-elements/brocade/test/com/cloud/network/element/Brocad
> ePluginTest.java PRE-CREATION
> 
> Diff: https://reviews.apache.org/r/6492/diff/
> 
> 
> Testing
> -------
> 
> Unit tests, Rest API calls from Rest client code
> 
> 
> Thanks,
> 
> Krishna Sadasivam
> 
>


Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6492/#review10050
-----------------------------------------------------------


Where does this file come from: deps/cloud-BrocadeService.jar

What is it licensed under? 
Link? 

--David

- David Nalley


On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6492/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 11:31 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> This is the patch for adding Brocade plugin to enable Brocade LBs in CloudStack. The plugin can support Lb service in advanced zone networking.
> Lb services: 
> *Protocols: TCP/UDP
> *Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin, weighted round robin static, enhanced weighted, responsetime
> *Sticky Session persistence using sticky port
> 
> 
> Diffs
> -----
> 
>   build/build-cloud-plugins.xml a7a1f39 
>   build/build-cloud.xml b4d120f 
>   build/developer.xml d52b682 
>   client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-CREATION 
>   client/tomcatconf/components.xml.in da7617d 
>   deps/.classpath 1376b4f 
>   deps/cloud-BrocadeService.jar PRE-CREATION 
>   plugins/network-elements/brocade/.classpath PRE-CREATION 
>   plugins/network-elements/brocade/.project PRE-CREATION 
>   plugins/network-elements/brocade/build.xml PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNetworksCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerResponse.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElementService.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java PRE-CREATION 
>   plugins/network-elements/brocade/test/com/cloud/network/element/Base64.java PRE-CREATION 
>   plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6492/diff/
> 
> 
> Testing
> -------
> 
> Unit tests, Rest API calls from Rest client code 
> 
> 
> Thanks,
> 
> Krishna Sadasivam
> 
>


Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Pattabi Ayyasami <pa...@brocade.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6492/#review15472
-----------------------------------------------------------


We will rebase rebase the code to master and incorporate/respond back to the review comments and resubmit the patch to the review board next week.

Regards,
Pattabi Ayyasami
Senior Manager, Brocade 

- Pattabi Ayyasami


On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6492/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 11:31 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> This is the patch for adding Brocade plugin to enable Brocade LBs in CloudStack. The plugin can support Lb service in advanced zone networking.
> Lb services: 
> *Protocols: TCP/UDP
> *Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin, weighted round robin static, enhanced weighted, responsetime
> *Sticky Session persistence using sticky port
> 
> 
> Diffs
> -----
> 
>   build/build-cloud-plugins.xml a7a1f39 
>   build/build-cloud.xml b4d120f 
>   build/developer.xml d52b682 
>   client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-CREATION 
>   client/tomcatconf/components.xml.in da7617d 
>   deps/.classpath 1376b4f 
>   deps/cloud-BrocadeService.jar PRE-CREATION 
>   plugins/network-elements/brocade/.classpath PRE-CREATION 
>   plugins/network-elements/brocade/.project PRE-CREATION 
>   plugins/network-elements/brocade/build.xml PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNetworksCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerResponse.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElementService.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java PRE-CREATION 
>   plugins/network-elements/brocade/test/com/cloud/network/element/Base64.java PRE-CREATION 
>   plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6492/diff/
> 
> 
> Testing
> -------
> 
> Unit tests, Rest API calls from Rest client code 
> 
> 
> Thanks,
> 
> Krishna Sadasivam
> 
>


Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6492/#review10534
-----------------------------------------------------------



plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java
<https://reviews.apache.org/r/6492/#comment22550>

    account ID and network ID are not being used. Can it be removed from API?



plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java
<https://reviews.apache.org/r/6492/#comment22548>

    What happens if Vm id is invalid? Should throw an invalid parameter exception.



plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java
<https://reviews.apache.org/r/6492/#comment22549>

    error message is wrong, function is setting weight not applying load balancer rules



plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java
<https://reviews.apache.org/r/6492/#comment22551>

    what happens if vlan already exists. There is no transaction like behavior, so if in the middle of sequence of steps, if an API fails, then configuration changes are rolled back. In such cases, it better to be resilient. 


- Murali Reddy


On Aug. 8, 2012, 11:31 p.m., Krishna Sadasivam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6492/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 11:31 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> This is the patch for adding Brocade plugin to enable Brocade LBs in CloudStack. The plugin can support Lb service in advanced zone networking.
> Lb services: 
> *Protocols: TCP/UDP
> *Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin, weighted round robin static, enhanced weighted, responsetime
> *Sticky Session persistence using sticky port
> 
> 
> Diffs
> -----
> 
>   build/build-cloud-plugins.xml a7a1f39 
>   build/build-cloud.xml b4d120f 
>   build/developer.xml d52b682 
>   client/tomcatconf/brocadeloadbalancer_commands.properties.in PRE-CREATION 
>   client/tomcatconf/components.xml.in da7617d 
>   deps/.classpath 1376b4f 
>   deps/cloud-BrocadeService.jar PRE-CREATION 
>   plugins/network-elements/brocade/.classpath PRE-CREATION 
>   plugins/network-elements/brocade/.project PRE-CREATION 
>   plugins/network-elements/brocade/build.xml PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeLoadBalancerCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancerNetworksCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoadBalancersCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCommand.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightForLbPredictorCmd.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBalancerResponse.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElement.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoadBalancerElementService.java PRE-CREATION 
>   plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADXResource.java PRE-CREATION 
>   plugins/network-elements/brocade/test/com/cloud/network/element/Base64.java PRE-CREATION 
>   plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6492/diff/
> 
> 
> Testing
> -------
> 
> Unit tests, Rest API calls from Rest client code 
> 
> 
> Thanks,
> 
> Krishna Sadasivam
> 
>


RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Krishna Sadasivam <ks...@Brocade.com>.
Thanks for your feedback.

Here are list of capabilities in the current patch:
* There is no virtual appliance for ADX as of now. The Virtual ADX itself is in development. So CloudStack support for software LB is not available in this patch.
* Brocade ADX will be LB provider in advanced zone only. I am still looking at what is required to make it work in basic zone.
* Static Nat commands are implemented. However EIP support is not intended. 
* We are add a pool of ADX devices to a physical network. Both dedicated and shared mode are supported. 

Thanks,
Krishna  

-----Original Message-----
From: Murali Reddy [mailto:Murali.Reddy@citrix.com] 
Sent: Thursday, August 09, 2012 2:08 AM
To: cloudstack-dev@incubator.apache.org; Krishna Sadasivam
Subject: Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack


Thanks for submitting patch. I took a quick look at the patch in general things look good. It would be better if you can give quick context on the ADX capabilities for better deatiled review. Some question I had was does ADX has a virtual appliance? NAT capabilities? Also where do you want to position Brocade ADX as LB provider in advanced zone only or both advanced and basic zones? I see that you implemented static NAT commands also, do you intend that with this patch Brocade SDX can be EIP provider in basic zone? I think currently EIP is hard coded to be provided by NetScaler devices, so you might want to relax that restriction for ADX to be EIP provider.

You may be aware, but just wanted to let you know. CloudStack has support for notion of pool of load balancer that can cloud-operator provision into a zone, so there could more than one ADX device in a physical network with the ability to offer a dedicated/shared load balancers based on the network offering. So please call out what patch is supporting. Let me know if you need any further details.


On 09/08/12 5:01 AM, "Krishna Sadasivam" <ks...@brocade.com> wrote:

>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/6492/
>-----------------------------------------------------------
>
>Review request for cloudstack.
>
>
>Description
>-------
>
>This is the patch for adding Brocade plugin to enable Brocade LBs in 
>CloudStack. The plugin can support Lb service in advanced zone networking.
>Lb services: 
>*Protocols: TCP/UDP
>*Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin, 
>weighted round robin static, enhanced weighted, responsetime *Sticky 
>Session persistence using sticky port
>
>
>Diffs
>-----
>
>  build/build-cloud-plugins.xml a7a1f39
>  build/build-cloud.xml b4d120f
>  build/developer.xml d52b682
>  client/tomcatconf/brocadeloadbalancer_commands.properties.in
>PRE-CREATION
>  client/tomcatconf/components.xml.in da7617d
>  deps/.classpath 1376b4f
>  deps/cloud-BrocadeService.jar PRE-CREATION
>  plugins/network-elements/brocade/.classpath PRE-CREATION
>  plugins/network-elements/brocade/.project PRE-CREATION
>  plugins/network-elements/brocade/build.xml PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeL
>oad
>BalancerCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBr
>oca
>deLoadBalancerCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBroca
>deL
>oadBalancerCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocade
>Loa
>dBalancerNetworksCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocade
>Loa
>dBalancersCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeight
>Com
>mand.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeight
>For
>LbPredictorCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoad
>Bal
>ancerResponse.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeE
>lem
>ent.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeL
>oad BalancerElementService.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/network/resource/Brocade
>ADX
>Resource.java PRE-CREATION
>  
>plugins/network-elements/brocade/test/com/cloud/network/element/Base64.
>jav
>a PRE-CREATION
>  
>plugins/network-elements/brocade/test/com/cloud/network/element/Brocade
>Plu
>ginTest.java PRE-CREATION
>
>Diff: https://reviews.apache.org/r/6492/diff/
>
>
>Testing
>-------
>
>Unit tests, Rest API calls from Rest client code
>
>
>Thanks,
>
>Krishna Sadasivam
>
>



Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Chiradeep Vittal <Ch...@citrix.com>.
There should be an FS + User guide (so that docs can indicate how to use
this)

On 8/17/12 6:31 AM, "Murali Reddy" <Mu...@citrix.com> wrote:

>On 15/08/12 3:00 AM, "Krishna Sadasivam" <ks...@Brocade.com> wrote:
>
>>I have submitted a new clean patch.
>>
>>Thanks,
>>Krishna
>
>I will review the patch over the week end. Please get the license issue
>sorted out for 'deps/cloud-BrocadeService.jar' mean while.
>


Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Murali Reddy <Mu...@citrix.com>.
On 15/08/12 3:00 AM, "Krishna Sadasivam" <ks...@Brocade.com> wrote:

>I have submitted a new clean patch.
>
>Thanks,
>Krishna

I will review the patch over the week end. Please get the license issue
sorted out for 'deps/cloud-BrocadeService.jar' mean while.


RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Krishna Sadasivam <ks...@Brocade.com>.
I have submitted a new clean patch.

Thanks,
Krishna

-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com] 
Sent: Friday, August 10, 2012 7:23 PM
To: Krishna Sadasivam
Cc: cloudstack-dev@incubator.apache.org
Subject: Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

You probably need to do an interactive git rebase, and squash your local commits into one. Then generate a patch from that clean commit.

- chip

Sent from my iPhone.

On Aug 10, 2012, at 10:03 PM, Krishna Sadasivam <ks...@brocade.com> wrote:

> I changed the BrocadePluginTest.java to use org.apache.commons.codec.binary.Base64. When I create a patch and try to upload to review board I get the following error:
>
> " The file 'plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java' (r0b8fd2c) could not be found in the repository"
>
> What is the best way to submit this diff given that the repository does not yet have this file?
>
> Thanks,
> Krishna
>
> -----Original Message-----
> From: Krishna Sadasivam
> Sent: Friday, August 10, 2012 10:53 AM
> To: Chip Childers; cloudstack-dev@incubator.apache.org
> Subject: RE: Review Request: Plugin for enabling Brocade as external 
> load balancing service provider in CloudStack
>
> I will try using org.apache.commons.codec.binary.Base64 and submit a patch.
>
> Thanks,
> Krishna
>
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Friday, August 10, 2012 7:29 AM
> To: cloudstack-dev@incubator.apache.org
> Cc: Krishna Sadasivam
> Subject: Re: Review Request: Plugin for enabling Brocade as external 
> load balancing service provider in CloudStack
>
> Yes,
>
> Krishna, can you please use the Base64 class that's available in deps/cloud-commons-codec-1.5.jar ?
>
> org.apache.commons.codec.binary.Base64
>
> -chip
>
> On Fri, Aug 10, 2012 at 10:18 AM, Murali Reddy <Mu...@citrix.com> wrote:
>> On 09/08/12 5:01 AM, "Krishna Sadasivam" <ks...@brocade.com> wrote:
>>
>>>
>>> plugins/network-elements/brocade/test/com/cloud/network/element/Base
>>> 64
>>> .jav
>>> a PRE-CREATION
>>
>> Should Base64.java be of concern from ASF license perspective? I 
>> think Alex removed it [1] from the repo and this patch will 
>> re-introduce if it goes to 4.0.
>>
>>
>> [1]
>> http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201
>> 2
>> 08.mb
>> ox/%3cB1DF26ECC0458748AC97CECE2DA98D41012F9EB3828C@SJCPMAILBOX01.citr
>> i
>> te.ne
>> t%3e
>>
>>
>

Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Chip Childers <ch...@sungard.com>.
You probably need to do an interactive git rebase, and squash your
local commits into one. Then generate a patch from that clean commit.

- chip

Sent from my iPhone.

On Aug 10, 2012, at 10:03 PM, Krishna Sadasivam <ks...@brocade.com> wrote:

> I changed the BrocadePluginTest.java to use org.apache.commons.codec.binary.Base64. When I create a patch and try to upload to review board I get the following error:
>
> " The file 'plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java' (r0b8fd2c) could not be found in the repository"
>
> What is the best way to submit this diff given that the repository does not yet have this file?
>
> Thanks,
> Krishna
>
> -----Original Message-----
> From: Krishna Sadasivam
> Sent: Friday, August 10, 2012 10:53 AM
> To: Chip Childers; cloudstack-dev@incubator.apache.org
> Subject: RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack
>
> I will try using org.apache.commons.codec.binary.Base64 and submit a patch.
>
> Thanks,
> Krishna
>
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Friday, August 10, 2012 7:29 AM
> To: cloudstack-dev@incubator.apache.org
> Cc: Krishna Sadasivam
> Subject: Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack
>
> Yes,
>
> Krishna, can you please use the Base64 class that's available in deps/cloud-commons-codec-1.5.jar ?
>
> org.apache.commons.codec.binary.Base64
>
> -chip
>
> On Fri, Aug 10, 2012 at 10:18 AM, Murali Reddy <Mu...@citrix.com> wrote:
>> On 09/08/12 5:01 AM, "Krishna Sadasivam" <ks...@brocade.com> wrote:
>>
>>>
>>> plugins/network-elements/brocade/test/com/cloud/network/element/Base64
>>> .jav
>>> a PRE-CREATION
>>
>> Should Base64.java be of concern from ASF license perspective? I think
>> Alex removed it [1] from the repo and this patch will re-introduce if
>> it goes to 4.0.
>>
>>
>> [1]
>> http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/2012
>> 08.mb
>> ox/%3cB1DF26ECC0458748AC97CECE2DA98D41012F9EB3828C@SJCPMAILBOX01.citri
>> te.ne
>> t%3e
>>
>>
>

RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Krishna Sadasivam <ks...@Brocade.com>.
I changed the BrocadePluginTest.java to use org.apache.commons.codec.binary.Base64. When I create a patch and try to upload to review board I get the following error:

" The file 'plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java' (r0b8fd2c) could not be found in the repository"

What is the best way to submit this diff given that the repository does not yet have this file?

Thanks,
Krishna

-----Original Message-----
From: Krishna Sadasivam 
Sent: Friday, August 10, 2012 10:53 AM
To: Chip Childers; cloudstack-dev@incubator.apache.org
Subject: RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

I will try using org.apache.commons.codec.binary.Base64 and submit a patch.

Thanks,
Krishna

-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com]
Sent: Friday, August 10, 2012 7:29 AM
To: cloudstack-dev@incubator.apache.org
Cc: Krishna Sadasivam
Subject: Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Yes,

Krishna, can you please use the Base64 class that's available in deps/cloud-commons-codec-1.5.jar ?

org.apache.commons.codec.binary.Base64

-chip

On Fri, Aug 10, 2012 at 10:18 AM, Murali Reddy <Mu...@citrix.com> wrote:
> On 09/08/12 5:01 AM, "Krishna Sadasivam" <ks...@brocade.com> wrote:
>
>>
>>plugins/network-elements/brocade/test/com/cloud/network/element/Base64
>>.jav
>>a PRE-CREATION
>
> Should Base64.java be of concern from ASF license perspective? I think 
> Alex removed it [1] from the repo and this patch will re-introduce if 
> it goes to 4.0.
>
>
> [1]
> http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/2012
> 08.mb
> ox/%3cB1DF26ECC0458748AC97CECE2DA98D41012F9EB3828C@SJCPMAILBOX01.citri
> te.ne
> t%3e
>
>

RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Krishna Sadasivam <ks...@Brocade.com>.
I will try using org.apache.commons.codec.binary.Base64 and submit a patch.

Thanks,
Krishna

-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com] 
Sent: Friday, August 10, 2012 7:29 AM
To: cloudstack-dev@incubator.apache.org
Cc: Krishna Sadasivam
Subject: Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Yes,

Krishna, can you please use the Base64 class that's available in deps/cloud-commons-codec-1.5.jar ?

org.apache.commons.codec.binary.Base64

-chip

On Fri, Aug 10, 2012 at 10:18 AM, Murali Reddy <Mu...@citrix.com> wrote:
> On 09/08/12 5:01 AM, "Krishna Sadasivam" <ks...@brocade.com> wrote:
>
>>
>>plugins/network-elements/brocade/test/com/cloud/network/element/Base64
>>.jav
>>a PRE-CREATION
>
> Should Base64.java be of concern from ASF license perspective? I think 
> Alex removed it [1] from the repo and this patch will re-introduce if 
> it goes to 4.0.
>
>
> [1]
> http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/2012
> 08.mb 
> ox/%3cB1DF26ECC0458748AC97CECE2DA98D41012F9EB3828C@SJCPMAILBOX01.citri
> te.ne
> t%3e
>
>

Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Chip Childers <ch...@sungard.com>.
Yes,

Krishna, can you please use the Base64 class that's available in
deps/cloud-commons-codec-1.5.jar ?

org.apache.commons.codec.binary.Base64

-chip

On Fri, Aug 10, 2012 at 10:18 AM, Murali Reddy <Mu...@citrix.com> wrote:
> On 09/08/12 5:01 AM, "Krishna Sadasivam" <ks...@brocade.com> wrote:
>
>>
>>plugins/network-elements/brocade/test/com/cloud/network/element/Base64.jav
>>a PRE-CREATION
>
> Should Base64.java be of concern from ASF license perspective? I think
> Alex removed it [1] from the repo and this patch will re-introduce if it
> goes to 4.0.
>
>
> [1]
> http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201208.mb
> ox/%3cB1DF26ECC0458748AC97CECE2DA98D41012F9EB3828C@SJCPMAILBOX01.citrite.ne
> t%3e
>
>

Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Murali Reddy <Mu...@citrix.com>.
Thanks for submitting patch. I took a quick look at the patch in general
things look good. It would be better if you can give quick context on the
ADX capabilities for better deatiled review. Some question I had was does
ADX has a virtual appliance? NAT capabilities? Also where do you want to
position Brocade ADX as LB provider in advanced zone only or both advanced
and basic zones? I see that you implemented static NAT commands also, do
you intend that with this patch Brocade SDX can be EIP provider in basic
zone? I think currently EIP is hard coded to be provided by NetScaler
devices, so you might want to relax that restriction for ADX to be EIP
provider.

You may be aware, but just wanted to let you know. CloudStack has support
for notion of pool of load balancer that can cloud-operator provision into
a zone, so there could more than one ADX device in a physical network with
the ability to offer a dedicated/shared load balancers based on the
network offering. So please call out what patch is supporting. Let me know
if you need any further details.


On 09/08/12 5:01 AM, "Krishna Sadasivam" <ks...@brocade.com> wrote:

>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/6492/
>-----------------------------------------------------------
>
>Review request for cloudstack.
>
>
>Description
>-------
>
>This is the patch for adding Brocade plugin to enable Brocade LBs in
>CloudStack. The plugin can support Lb service in advanced zone networking.
>Lb services: 
>*Protocols: TCP/UDP
>*Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin,
>weighted round robin static, enhanced weighted, responsetime
>*Sticky Session persistence using sticky port
>
>
>Diffs
>-----
>
>  build/build-cloud-plugins.xml a7a1f39
>  build/build-cloud.xml b4d120f
>  build/developer.xml d52b682
>  client/tomcatconf/brocadeloadbalancer_commands.properties.in
>PRE-CREATION 
>  client/tomcatconf/components.xml.in da7617d
>  deps/.classpath 1376b4f
>  deps/cloud-BrocadeService.jar PRE-CREATION
>  plugins/network-elements/brocade/.classpath PRE-CREATION
>  plugins/network-elements/brocade/.project PRE-CREATION
>  plugins/network-elements/brocade/build.xml PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeLoad
>BalancerCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBroca
>deLoadBalancerCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBrocadeL
>oadBalancerCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoa
>dBalancerNetworksCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocadeLoa
>dBalancersCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightCom
>mand.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeightFor
>LbPredictorCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoadBal
>ancerResponse.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeElem
>ent.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeLoad
>BalancerElementService.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/network/resource/BrocadeADX
>Resource.java PRE-CREATION
>  
>plugins/network-elements/brocade/test/com/cloud/network/element/Base64.jav
>a PRE-CREATION 
>  
>plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePlu
>ginTest.java PRE-CREATION
>
>Diff: https://reviews.apache.org/r/6492/diff/
>
>
>Testing
>-------
>
>Unit tests, Rest API calls from Rest client code
>
>
>Thanks,
>
>Krishna Sadasivam
>
>



Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

Posted by Murali Reddy <Mu...@citrix.com>.
On 09/08/12 5:01 AM, "Krishna Sadasivam" <ks...@brocade.com> wrote:

>  
>plugins/network-elements/brocade/test/com/cloud/network/element/Base64.jav
>a PRE-CREATION

Should Base64.java be of concern from ASF license perspective? I think
Alex removed it [1] from the repo and this patch will re-introduce if it
goes to 4.0.


[1] 
http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201208.mb
ox/%3cB1DF26ECC0458748AC97CECE2DA98D41012F9EB3828C@SJCPMAILBOX01.citrite.ne
t%3e