You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/07/24 04:46:07 UTC

Review Request: Fix for Allocator Failover

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6116/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and John Sirois.


Description
-------

Allocator needs to call allocate() once a framework's been activated


Diffs
-----

  src/master/dominant_share_allocator.cpp 58ed832 

Diff: https://reviews.apache.org/r/6116/diff/


Testing
-------


Thanks,

Vinod Kone

Re: Review Request: Fix for Allocator Failover

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6116/#review9388
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On July 24, 2012, 2:46 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6116/
> -----------------------------------------------------------
> 
> (Updated July 24, 2012, 2:46 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and John Sirois.
> 
> 
> Description
> -------
> 
> Allocator needs to call allocate() once a framework's been activated
> 
> 
> Diffs
> -----
> 
>   src/master/dominant_share_allocator.cpp 58ed832 
> 
> Diff: https://reviews.apache.org/r/6116/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request: Fix for Allocator Failover

Posted by John Sirois <jo...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6116/#review9389
-----------------------------------------------------------



src/master/dominant_share_allocator.cpp
<https://reviews.apache.org/r/6116/#comment20118>

    seems like frameworkAdded should be chaining frameworkActivated


- John Sirois


On July 24, 2012, 2:46 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6116/
> -----------------------------------------------------------
> 
> (Updated July 24, 2012, 2:46 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and John Sirois.
> 
> 
> Description
> -------
> 
> Allocator needs to call allocate() once a framework's been activated
> 
> 
> Diffs
> -----
> 
>   src/master/dominant_share_allocator.cpp 58ed832 
> 
> Diff: https://reviews.apache.org/r/6116/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>