You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Randall Leeds (JIRA)" <ji...@apache.org> on 2011/01/27 00:32:43 UTC
[jira] Created: (COUCHDB-1042) make libcurl a soft (optional)
dependency
make libcurl a soft (optional) dependency
-----------------------------------------
Key: COUCHDB-1042
URL: https://issues.apache.org/jira/browse/COUCHDB-1042
Project: CouchDB
Issue Type: Improvement
Components: Build System
Affects Versions: 1.0.1
Reporter: Randall Leeds
Priority: Minor
Fix For: 1.2, 2.0
Attachments: 0001-make-cURL-an-optional-dependency.patch
CouchDB currently uses libcurl only in couchjs to expose HTTP client functions to the JavaScript environment. This functionality is used by the JavaScript unit tests. For idempotent views it is discouraged to perform I/O in a view function. Therefore, I propose that libcurl be made an optional dependency, automatically detected at build time, and a flag added to couchjs so it can be explicitly enabled in the unit tests (but disabled, by default, for the query server).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (COUCHDB-1042) make libcurl a soft (optional)
dependency
Posted by "Randall Leeds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Randall Leeds reopened COUCHDB-1042:
------------------------------------
Reopening because another patch is needed to fully close.
> make libcurl a soft (optional) dependency
> -----------------------------------------
>
> Key: COUCHDB-1042
> URL: https://issues.apache.org/jira/browse/COUCHDB-1042
> Project: CouchDB
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Priority: Minor
> Fix For: 1.2, 2.0
>
> Attachments: 0001-make-cURL-an-optional-dependency.patch, 0001-no-lcurl-if-no-curl-support.patch, curl_as_soft_dep.patch, curl_as_soft_dep_v2.patch
>
>
> CouchDB currently uses libcurl only in couchjs to expose HTTP client functions to the JavaScript environment. This functionality is used by the JavaScript unit tests. For idempotent views it is discouraged to perform I/O in a view function. Therefore, I propose that libcurl be made an optional dependency, automatically detected at build time, and a flag added to couchjs so it can be explicitly enabled in the unit tests (but disabled, by default, for the query server).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (COUCHDB-1042) make libcurl a soft (optional)
dependency
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Joseph Davis resolved COUCHDB-1042.
----------------------------------------
Resolution: Fixed
Shipped. Updated NEWS, CHANGES, and INSTALL while I was at it.
> make libcurl a soft (optional) dependency
> -----------------------------------------
>
> Key: COUCHDB-1042
> URL: https://issues.apache.org/jira/browse/COUCHDB-1042
> Project: CouchDB
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Priority: Minor
> Fix For: 1.2, 2.0
>
> Attachments: 0001-make-cURL-an-optional-dependency.patch, curl_as_soft_dep.patch, curl_as_soft_dep_v2.patch
>
>
> CouchDB currently uses libcurl only in couchjs to expose HTTP client functions to the JavaScript environment. This functionality is used by the JavaScript unit tests. For idempotent views it is discouraged to perform I/O in a view function. Therefore, I propose that libcurl be made an optional dependency, automatically detected at build time, and a flag added to couchjs so it can be explicitly enabled in the unit tests (but disabled, by default, for the query server).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Resolved] (COUCHDB-1042) make libcurl a soft (optional)
dependency
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Joseph Davis resolved COUCHDB-1042.
----------------------------------------
Resolution: Fixed
Randall's patch applied in 1086934
> make libcurl a soft (optional) dependency
> -----------------------------------------
>
> Key: COUCHDB-1042
> URL: https://issues.apache.org/jira/browse/COUCHDB-1042
> Project: CouchDB
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Priority: Minor
> Fix For: 1.2, 2.0
>
> Attachments: 0001-make-cURL-an-optional-dependency.patch, 0001-no-lcurl-if-no-curl-support.patch, curl_as_soft_dep.patch, curl_as_soft_dep_v2.patch
>
>
> CouchDB currently uses libcurl only in couchjs to expose HTTP client functions to the JavaScript environment. This functionality is used by the JavaScript unit tests. For idempotent views it is discouraged to perform I/O in a view function. Therefore, I propose that libcurl be made an optional dependency, automatically detected at build time, and a flag added to couchjs so it can be explicitly enabled in the unit tests (but disabled, by default, for the query server).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (COUCHDB-1042) make libcurl a soft (optional)
dependency
Posted by "Randall Leeds (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Randall Leeds reopened COUCHDB-1042:
------------------------------------
Skill Level: New Contributors Level (Easy)
Assignee: Randall Leeds
I think now that the js tests run with make check something is needed here. We should issue a warning that these tests won't be run when the dependency isn't satisfied, and then not run them.
> make libcurl a soft (optional) dependency
> -----------------------------------------
>
> Key: COUCHDB-1042
> URL: https://issues.apache.org/jira/browse/COUCHDB-1042
> Project: CouchDB
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Assignee: Randall Leeds
> Priority: Minor
> Fix For: 1.2, 2.0
>
> Attachments: 0001-make-cURL-an-optional-dependency.patch, 0001-no-lcurl-if-no-curl-support.patch, curl_as_soft_dep.patch, curl_as_soft_dep_v2.patch
>
>
> CouchDB currently uses libcurl only in couchjs to expose HTTP client functions to the JavaScript environment. This functionality is used by the JavaScript unit tests. For idempotent views it is discouraged to perform I/O in a view function. Therefore, I propose that libcurl be made an optional dependency, automatically detected at build time, and a flag added to couchjs so it can be explicitly enabled in the unit tests (but disabled, by default, for the query server).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COUCHDB-1042) make libcurl a soft (optional)
dependency
Posted by "Randall Leeds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Randall Leeds updated COUCHDB-1042:
-----------------------------------
Attachment: 0001-no-lcurl-if-no-curl-support.patch
The following patch fully resolves this issue.
> make libcurl a soft (optional) dependency
> -----------------------------------------
>
> Key: COUCHDB-1042
> URL: https://issues.apache.org/jira/browse/COUCHDB-1042
> Project: CouchDB
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Priority: Minor
> Fix For: 1.2, 2.0
>
> Attachments: 0001-make-cURL-an-optional-dependency.patch, 0001-no-lcurl-if-no-curl-support.patch, curl_as_soft_dep.patch, curl_as_soft_dep_v2.patch
>
>
> CouchDB currently uses libcurl only in couchjs to expose HTTP client functions to the JavaScript environment. This functionality is used by the JavaScript unit tests. For idempotent views it is discouraged to perform I/O in a view function. Therefore, I propose that libcurl be made an optional dependency, automatically detected at build time, and a flag added to couchjs so it can be explicitly enabled in the unit tests (but disabled, by default, for the query server).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COUCHDB-1042) make libcurl a soft (optional)
dependency
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Joseph Davis updated COUCHDB-1042:
---------------------------------------
Attachment: (was: curl_as_soft_dep.patch)
> make libcurl a soft (optional) dependency
> -----------------------------------------
>
> Key: COUCHDB-1042
> URL: https://issues.apache.org/jira/browse/COUCHDB-1042
> Project: CouchDB
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Priority: Minor
> Fix For: 1.2, 2.0
>
> Attachments: 0001-make-cURL-an-optional-dependency.patch, curl_as_soft_dep.patch
>
>
> CouchDB currently uses libcurl only in couchjs to expose HTTP client functions to the JavaScript environment. This functionality is used by the JavaScript unit tests. For idempotent views it is discouraged to perform I/O in a view function. Therefore, I propose that libcurl be made an optional dependency, automatically detected at build time, and a flag added to couchjs so it can be explicitly enabled in the unit tests (but disabled, by default, for the query server).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-1042) make libcurl a soft (optional)
dependency
Posted by "Randall Leeds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Randall Leeds updated COUCHDB-1042:
-----------------------------------
Attachment: curl_as_soft_dep_v2.patch
Two small changes.
1) combined the sed regex. just cause. so there.
2) removed whitespace from a line in main.c
Ship it.
> make libcurl a soft (optional) dependency
> -----------------------------------------
>
> Key: COUCHDB-1042
> URL: https://issues.apache.org/jira/browse/COUCHDB-1042
> Project: CouchDB
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Priority: Minor
> Fix For: 1.2, 2.0
>
> Attachments: 0001-make-cURL-an-optional-dependency.patch, curl_as_soft_dep.patch, curl_as_soft_dep_v2.patch
>
>
> CouchDB currently uses libcurl only in couchjs to expose HTTP client functions to the JavaScript environment. This functionality is used by the JavaScript unit tests. For idempotent views it is discouraged to perform I/O in a view function. Therefore, I propose that libcurl be made an optional dependency, automatically detected at build time, and a flag added to couchjs so it can be explicitly enabled in the unit tests (but disabled, by default, for the query server).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Closed] (COUCHDB-1042) make libcurl a soft (optional)
dependency
Posted by "Randall Leeds (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Randall Leeds closed COUCHDB-1042.
----------------------------------
Resolution: Fixed
Resolved again by 39d81d5..bf7c74e
> make libcurl a soft (optional) dependency
> -----------------------------------------
>
> Key: COUCHDB-1042
> URL: https://issues.apache.org/jira/browse/COUCHDB-1042
> Project: CouchDB
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Assignee: Randall Leeds
> Priority: Minor
> Fix For: 1.2, 2.0
>
> Attachments: 0001-make-cURL-an-optional-dependency.patch, 0001-no-lcurl-if-no-curl-support.patch, curl_as_soft_dep.patch, curl_as_soft_dep_v2.patch
>
>
> CouchDB currently uses libcurl only in couchjs to expose HTTP client functions to the JavaScript environment. This functionality is used by the JavaScript unit tests. For idempotent views it is discouraged to perform I/O in a view function. Therefore, I propose that libcurl be made an optional dependency, automatically detected at build time, and a flag added to couchjs so it can be explicitly enabled in the unit tests (but disabled, by default, for the query server).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COUCHDB-1042) make libcurl a soft (optional)
dependency
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Joseph Davis updated COUCHDB-1042:
---------------------------------------
Attachment: curl_as_soft_dep.patch
Just a slightly modified patch that agrees on most bits.
Only big changes are that http.c puts the "no curl support" version at the top so that people that just open the file will realize straight away why the whole file is enclosed in a #ifndef instead of being required to scroll all the way to the bottom.
Second bit cleans up the command line parsing in couchjs (binary) by doing a couple extra steps in couchjs shell script. I'm not as enamored with this bit so if you think your way is better feel free to reject that part. Thought he http.c ifdef switch I would like to keep.
> make libcurl a soft (optional) dependency
> -----------------------------------------
>
> Key: COUCHDB-1042
> URL: https://issues.apache.org/jira/browse/COUCHDB-1042
> Project: CouchDB
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Priority: Minor
> Fix For: 1.2, 2.0
>
> Attachments: 0001-make-cURL-an-optional-dependency.patch, curl_as_soft_dep.patch
>
>
> CouchDB currently uses libcurl only in couchjs to expose HTTP client functions to the JavaScript environment. This functionality is used by the JavaScript unit tests. For idempotent views it is discouraged to perform I/O in a view function. Therefore, I propose that libcurl be made an optional dependency, automatically detected at build time, and a flag added to couchjs so it can be explicitly enabled in the unit tests (but disabled, by default, for the query server).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-1042) make libcurl a soft (optional)
dependency
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Joseph Davis updated COUCHDB-1042:
---------------------------------------
Attachment: curl_as_soft_dep.patch
Whoops. Typo in the last version.
> make libcurl a soft (optional) dependency
> -----------------------------------------
>
> Key: COUCHDB-1042
> URL: https://issues.apache.org/jira/browse/COUCHDB-1042
> Project: CouchDB
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Priority: Minor
> Fix For: 1.2, 2.0
>
> Attachments: 0001-make-cURL-an-optional-dependency.patch, curl_as_soft_dep.patch
>
>
> CouchDB currently uses libcurl only in couchjs to expose HTTP client functions to the JavaScript environment. This functionality is used by the JavaScript unit tests. For idempotent views it is discouraged to perform I/O in a view function. Therefore, I propose that libcurl be made an optional dependency, automatically detected at build time, and a flag added to couchjs so it can be explicitly enabled in the unit tests (but disabled, by default, for the query server).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-1042) make libcurl a soft (optional)
dependency
Posted by "Randall Leeds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Randall Leeds updated COUCHDB-1042:
-----------------------------------
Attachment: 0001-make-cURL-an-optional-dependency.patch
Patch that solves the issue as described.
Tested both with and without a compliant cURL installation.
> make libcurl a soft (optional) dependency
> -----------------------------------------
>
> Key: COUCHDB-1042
> URL: https://issues.apache.org/jira/browse/COUCHDB-1042
> Project: CouchDB
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Priority: Minor
> Fix For: 1.2, 2.0
>
> Attachments: 0001-make-cURL-an-optional-dependency.patch
>
>
> CouchDB currently uses libcurl only in couchjs to expose HTTP client functions to the JavaScript environment. This functionality is used by the JavaScript unit tests. For idempotent views it is discouraged to perform I/O in a view function. Therefore, I propose that libcurl be made an optional dependency, automatically detected at build time, and a flag added to couchjs so it can be explicitly enabled in the unit tests (but disabled, by default, for the query server).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.