You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/04/27 23:41:33 UTC
[GitHub] [yunikorn-k8shim] craigcondit opened a new pull request, #580: [YUNIKORN-1615] Ensure node coordinator accounts for all non-yunikorn pod updates
craigcondit opened a new pull request, #580:
URL: https://github.com/apache/yunikorn-k8shim/pull/580
Under certain circumstances, the node coordinator has been observed updating occupied resources on a node to negative values.
Ensure that we handle all pod add/update/delete events for non-yunikorn pods appropriately.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1615
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit commented on pull request #580: [WIP] [YUNIKORN-1615] Ensure node coordinator accounts for all non-yunikorn pod updates
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on PR #580:
URL: https://github.com/apache/yunikorn-k8shim/pull/580#issuecomment-1527755689
Reverting to draft as this is broken (counts occupied resources double on startup due to context_recovery handling conflicts).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-1615] Ensure node coordinator accounts for all non-yunikorn pod updates [yunikorn-k8shim]
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #580: [YUNIKORN-1615] Ensure node coordinator accounts for all non-yunikorn pod updates
URL: https://github.com/apache/yunikorn-k8shim/pull/580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-1615] Ensure node coordinator accounts for all non-yunikorn pod updates [yunikorn-k8shim]
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on PR #580:
URL: https://github.com/apache/yunikorn-k8shim/pull/580#issuecomment-1864879134
Closing in favor of #734.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #580: [YUNIKORN-1615] Ensure node coordinator accounts for all non-yunikorn pod updates
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #580:
URL: https://github.com/apache/yunikorn-k8shim/pull/580#issuecomment-1526790562
## [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/580?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#580](https://codecov.io/gh/apache/yunikorn-k8shim/pull/580?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f84eb9) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/523b6f023d8da78b8b5f2d604efe605a130cbaba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (523b6f0) will **increase** coverage by `0.09%`.
> The diff coverage is `92.85%`.
```diff
@@ Coverage Diff @@
## master #580 +/- ##
==========================================
+ Coverage 69.97% 70.07% +0.09%
==========================================
Files 47 47
Lines 7943 7979 +36
==========================================
+ Hits 5558 5591 +33
- Misses 2177 2179 +2
- Partials 208 209 +1
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `43.78% <0.00%> (-0.06%)` | :arrow_down: |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `72.26% <0.00%> (-0.27%)` | :arrow_down: |
| [pkg/cache/node\_coordinator.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGVfY29vcmRpbmF0b3IuZ28=) | `80.00% <95.58%> (+5.35%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://codecov.io/gh/apache/yunikorn-k8shim/pull/580/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org