[jira] [Commented] (CALCITE-1833) User-defined aggregate functions with more than one parameter

["yuemeng (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071889#comment-16071889 ] 

yuemeng commented on CALCITE-1833:
----------------------------------

[~julianhyde]
cau reivew this pr,thanks.
https://github.com/apache/calcite/pull/481


> User-defined aggregate functions with more than one parameter
> -------------------------------------------------------------
>
>                 Key: CALCITE-1833
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1833
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.12.0
>            Reporter: yuemeng
>            Assignee: yuemeng
>            Priority: Blocker
>         Attachments: 0001-CALCITE-1833-User-defined-aggregate-functions-with-m.patch
>
>
> Currently user-defined aggregate functions must have one parameter.
> SqlAggFunction need new constructor to set paramTypes to allow user-defined aggregate function to have more than one parameter.
> If a class(A) implement interface of AggregateFunction,that instance of class will be transformed to instance of  SqlUserDefinedAggFunction by call toOp method in CalciteCatalogReader.
> when construct the SqlUserDefinedAggFunction  instance will set paramTypes to null for super class sqlFunction indirectly.
> The problem is:
> we will  get SqlUserDefinedAggFunction paramTypes to sql validatefilte,but it will be filter nothing 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)