You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/21 06:40:15 UTC
[GitHub] [pulsar] wolfstudy opened a new pull request #10666: Add 2.7.3 docs for repo
wolfstudy opened a new pull request #10666:
URL: https://github.com/apache/pulsar/pull/10666
Signed-off-by: xiaolongran <xi...@tencent.com>
Fixes #10665
### Motivation
Add 2.7.3 docs for repo
### Modifications
- Add 2.7.3 docs in `versioned_docs`
- Add sidebars in `versioned_sidebars`
- Update release.json
- Update versions.json
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #10666: Add 2.7.3 docs for repo
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10666:
URL: https://github.com/apache/pulsar/pull/10666#issuecomment-845852740
@wolfstudy thanks for your contribution!
Seems that `release.json` and `versions.json` should be updated after 2.7.3 is released (at that time, 2.7.3 should be displayed on the website)
Take 2.7.2 for references: https://github.com/apache/pulsar/pull/10256#issuecomment-822506632 https://github.com/apache/pulsar/pull/10585
@Jennifer88huang @eolivelli please correct me if I'm wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #10666: Add 2.7.3 docs for repo
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #10666:
URL: https://github.com/apache/pulsar/pull/10666#issuecomment-846789341
@Anonymitaet @Jennifer88huang PTAL thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #10666: Add 2.7.3 docs for repo
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #10666:
URL: https://github.com/apache/pulsar/pull/10666#issuecomment-848425322
> > The 2.7.3 has not yet been released, so we can temporarily use it as a historical document. After 2.7.3 is released, we will show it to users as the main version of the document.
>
> I do not understand this comment, can you please explain ?
> we must not list 2.7.3 in the menu
Cool, will fix it, PTAL again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet edited a comment on pull request #10666: Add 2.7.3 docs for repo
Posted by GitBox <gi...@apache.org>.
Anonymitaet edited a comment on pull request #10666:
URL: https://github.com/apache/pulsar/pull/10666#issuecomment-845852740
@wolfstudy thanks for your contribution!
Seems that `release.json` and `versions.json` should be updated after 2.7.3 is released (at that time, 2.7.3 should be displayed on the website)
Take 2.7.2 for references:
- https://github.com/apache/pulsar/pull/10256#issuecomment-822506632
- https://github.com/apache/pulsar/pull/10585
@Jennifer88huang @eolivelli please correct me if I'm wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10666: Add 2.7.3 docs for repo
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10666:
URL: https://github.com/apache/pulsar/pull/10666#issuecomment-847742835
> The 2.7.3 has not yet been released, so we can temporarily use it as a historical document. After 2.7.3 is released, we will show it to users as the main version of the document.
I do not understand this comment, can you please explain ?
we must not list 2.7.3 in the menu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #10666: Add 2.7.3 docs for repo
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #10666:
URL: https://github.com/apache/pulsar/pull/10666#discussion_r638651161
##########
File path: site2/website/releases.json
##########
@@ -1,6 +1,7 @@
[
"2.7.2",
"2.7.1",
+ "2.7.3",
Review comment:
please do not add 2.7.3 here.
it has not been released
##########
File path: site2/website/versions.json
##########
@@ -1,6 +1,7 @@
[
"2.7.2",
"2.7.1",
+ "2.7.3",
Review comment:
please do not had 2.7.3, is has not been released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #10666: Add 2.7.3 docs for repo
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10666:
URL: https://github.com/apache/pulsar/pull/10666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #10666: Add 2.7.3 docs for repo
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #10666:
URL: https://github.com/apache/pulsar/pull/10666#issuecomment-846790330
> @wolfstudy thanks for your contribution!
>
> Seems that `release.json` and `versions.json` should be updated after 2.7.3 is released (at that time, 2.7.3 should be displayed on the website)
>
> Take 2.7.2 for references:
>
> * [#10256 (comment)](https://github.com/apache/pulsar/pull/10256#issuecomment-822506632)
> * #10585
>
> @Jennifer88huang @eolivelli please correct me if I'm wrong.
Yes, yu. The 2.7.3 has not yet been released, so we can temporarily use it as a historical document. After 2.7.3 is released, we will show it to users as the main version of the document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #10666: Add 2.7.3 docs for repo
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #10666:
URL: https://github.com/apache/pulsar/pull/10666#issuecomment-845860966
@wolfstudy great job. Thank you for taking the lead to do it.
@Anonymitaet Yes, you're correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org