You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/30 16:39:43 UTC
[GitHub] [arrow] kszucs opened a new pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
kszucs opened a new pull request #7074:
URL: https://github.com/apache/arrow/pull/7074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622396964
@github-actions crossbow submit wheel-win-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622494222
> @xhochy to run the wheels, or build them?
To run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-621967506
@github-actions crossbow submit wheel-win-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fsaintjacques commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
fsaintjacques commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622491245
@xhochy to run the wheels, or build them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622356800
@github-actions crossbow submit wheel-win-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-624015333
I'm not sure what's the verdict here, but this issue becomes pressing because of a possible upcoming patch release.
The python 3.5 script uses bundled dependencies except for boost python and zlib (no gandiva, no flight). I can try to switch back to vs2015 if you would prefer that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-624067669
Yeah, IMHO let's change to bundled dependencies and stick with VS2015 until we understand the implications of moving to the newer runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622319822
Revision: ea4f1375f4dcbc5fe7e81dc16b2c5c239bc30d30
Submitted crossbow builds: [ursa-labs/crossbow @ actions-191](https://github.com/ursa-labs/crossbow/branches/all?query=actions-191)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622496448
Is this change necessary? I understand why we are using VS2017 in the conda package but why in the wheels?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622023582
Revision: 5988be2a5f9b283a8bc1012714fc03ff57b453c4
Submitted crossbow builds: [ursa-labs/crossbow @ actions-187](https://github.com/ursa-labs/crossbow/branches/all?query=actions-187)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622729700
Actually, I think the most practical approach would be to use the conda-forge recipes, patch them to use `vs2015` and upload them to a separate channel. This gives us the build machinery to not rebuild them in every CI run and also keeps us from maintaining a complete set of build scripts, we just need to copy them over from time to time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622319449
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622697125
We would need to switch away from using the compiled conda packages as the basis for the wheels. I'm not sure if there is a different source that could provide except Arrow building them on their own.
With my Arrow hat on, this is really annoying as either build times will increase significantly or we would have to use make a pre-filled Windows Docker image that already includes all our static libraries.
With my conda-forge hat on, I would actually love to see this happen as this would mean that we could get rid of the static libraries which we actually don't want to build and distribute. As a package manager who can explicitly deal with native dependencies, dynamic linkage makes the package maintenance a whole lot easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-621968378
Revision: f64fd002135d7bb90cfb2725d01d3ccc73b809fa
Submitted crossbow builds: [ursa-labs/crossbow @ actions-186](https://github.com/ursa-labs/crossbow/branches/all?query=actions-186)
|Task|Status|
|----|------|
|wheel-win-cp35m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp36m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622397441
Revision: b65130bd5eae0e6fe79ace9d529a57f76869f621
Submitted crossbow builds: [ursa-labs/crossbow @ actions-195](https://github.com/ursa-labs/crossbow/branches/all?query=actions-195)
|Task|Status|
|----|------|
|wheel-win-cp35m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp36m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm edited a comment on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
wesm edited a comment on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-623026632
We could also use `BUNDLED` builds for the dependencies of interest (might also be nice to turn on ARROW_MIMALLOC while we are at it). We'd need to turn off Gandiva (and possibly Flight), though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622357099
Revision: 8852e2f5f32402ca9c85877289c7948db141cca7
Submitted crossbow builds: [ursa-labs/crossbow @ actions-194](https://github.com/ursa-labs/crossbow/branches/all?query=actions-194)
|Task|Status|
|----|------|
|wheel-win-cp35m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp36m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622022639
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622345879
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622045514
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622083097
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-623026632
We could also use `BUNDLED` builds for the dependencies of interest (might also be nice to turn on ARROW_MIMALLOC while we are at it). We'd need to turn off Gandiva, though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm edited a comment on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
wesm edited a comment on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622496448
Is this change necessary? I understand why we are using VS2017 in the conda package but why in the wheels? I'm sort of -0.5 on this unless there is a concrete reason why we can't keep using VS2015 (because it may require users to install a different C++ redistributable than the VS2015 one that other packages require)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622346215
Revision: 8852e2f5f32402ca9c85877289c7948db141cca7
Submitted crossbow builds: [ursa-labs/crossbow @ actions-193](https://github.com/ursa-labs/crossbow/branches/all?query=actions-193)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622102421
Revision: d17f2c212f28bf672a6f46d1dbe017d632707271
Submitted crossbow builds: [ursa-labs/crossbow @ actions-190](https://github.com/ursa-labs/crossbow/branches/all?query=actions-190)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-622051056
Revision: 5a0c01cc93b5d4357cab19b27f9397e977a76277
Submitted crossbow builds: [ursa-labs/crossbow @ actions-188](https://github.com/ursa-labs/crossbow/branches/all?query=actions-188)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7074: ARROW-8656: [Python] Switch to VS2017 in the windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7074:
URL: https://github.com/apache/arrow/pull/7074#issuecomment-621971057
https://issues.apache.org/jira/browse/ARROW-8656
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org