You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2016/02/19 22:13:00 UTC
Review Request 43784: Give the task status expand icon a pointer
cursor to make it clear that it's clickable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43784/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Zameer Manji.
Repository: aurora
Description
-------
Give the task status expand icon a pointer cursor to make it clear that it's clickable.
Diffs
-----
src/main/resources/scheduler/assets/css/app.css a1e2fbf09db507e859ebca87dc70cb0de7c5e361
src/main/resources/scheduler/assets/taskStatus.html 821783aca26b54c3b9c824f06ee7c18505ff4629
Diff: https://reviews.apache.org/r/43784/diff/
Testing
-------
Verified the pointer showed up in the UI.
Thanks,
Joshua Cohen
Re: Review Request 43784: Give the task status expand icon a pointer
cursor to make it clear that it's clickable.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43784/#review119975
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Feb. 19, 2016, 1:12 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43784/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 1:12 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Give the task status expand icon a pointer cursor to make it clear that it's clickable.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/css/app.css a1e2fbf09db507e859ebca87dc70cb0de7c5e361
> src/main/resources/scheduler/assets/taskStatus.html 821783aca26b54c3b9c824f06ee7c18505ff4629
>
> Diff: https://reviews.apache.org/r/43784/diff/
>
>
> Testing
> -------
>
> Verified the pointer showed up in the UI.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 43784: Give the task status expand icon a pointer
cursor to make it clear that it's clickable.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43784/#review119982
-----------------------------------------------------------
Master (8501d82) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 19, 2016, 9:12 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43784/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 9:12 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Give the task status expand icon a pointer cursor to make it clear that it's clickable.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/css/app.css a1e2fbf09db507e859ebca87dc70cb0de7c5e361
> src/main/resources/scheduler/assets/taskStatus.html 821783aca26b54c3b9c824f06ee7c18505ff4629
>
> Diff: https://reviews.apache.org/r/43784/diff/
>
>
> Testing
> -------
>
> Verified the pointer showed up in the UI.
>
>
> Thanks,
>
> Joshua Cohen
>
>