You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/08/26 12:29:37 UTC

[GitHub] [calcite] wangzzu commented on a change in pull request #1406: [CALCITE-3243] Incomplete validation of operands in JSON functions

wangzzu commented on a change in pull request #1406: [CALCITE-3243] Incomplete validation of operands in JSON functions
URL: https://github.com/apache/calcite/pull/1406#discussion_r317580102
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/fun/SqlJsonExistsFunction.java
 ##########
 @@ -34,14 +34,15 @@ public SqlJsonExistsFunction() {
     super("JSON_EXISTS", SqlKind.OTHER_FUNCTION,
         ReturnTypes.cascade(ReturnTypes.BOOLEAN, SqlTypeTransforms.FORCE_NULLABLE), null,
         OperandTypes.or(
-            OperandTypes.family(SqlTypeFamily.ANY, SqlTypeFamily.CHARACTER),
 
 Review comment:
   If calcite has supported JSON type, it can add some  `OperandTypes.family` to SqlOperandTypeChecker. Using SqlTypeFamily.ANY will prevent type validation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services