You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/08 08:34:56 UTC
[GitHub] [kafka] kowshik opened a new pull request #9393: KAFKA-10028: Minor fix to updateFeatures error message
kowshik opened a new pull request #9393:
URL: https://github.com/apache/kafka/pull/9393
In this PR, I have addressed the review comments from @chia7712 in https://github.com/apache/kafka/pull/9001 which were provided after https://github.com/apache/kafka/pull/9001 was merged. The changes are made mainly to `KafkaAdminClient`:
1. Improve error message in `updateFeatures` api when feature name is empty.
2. Propagate top-level error message in `updateFeatures` api.
3. Add an empty-parameter variety for `describeFeatures` api.
**Test plan:**
Relying on existing unit and integration tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao commented on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis
Posted by GitBox <gi...@apache.org>.
junrao commented on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705702092
In this PR, I have addressed the review comments from @chia7712 in #9001 which were provided after #9001 was merged. The changes are made mainly to KafkaAdminClient:
Improve error message in updateFeatures api when feature name is empty.
Propagate top-level error message in updateFeatures api.
Add an empty-parameter variety for describeFeatures api.
Minor documentation updates to @param and @return to make these resemble other apis.
Reviewers: Chia-Ping Tsai <ch...@gmail.com>, Jun Rao <ju...@gmail.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705449262
I can't merge it since I'm not a Kafka committer 😅
@junrao Could you please take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao removed a comment on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis
Posted by GitBox <gi...@apache.org>.
junrao removed a comment on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705702092
In this PR, I have addressed the review comments from @chia7712 in #9001 which were provided after #9001 was merged. The changes are made mainly to KafkaAdminClient:
Improve error message in updateFeatures api when feature name is empty.
Propagate top-level error message in updateFeatures api.
Add an empty-parameter variety for describeFeatures api.
Minor documentation updates to @param and @return to make these resemble other apis.
Reviewers: Chia-Ping Tsai <ch...@gmail.com>, Jun Rao <ju...@gmail.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705449262
I can't merge it since I'm not a Kafka committer 😅
@junrao Could you please take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705444078
@chia7712 thanks for the review! would you be able to please help merge this PR into trunk when CI passes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao merged pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis
Posted by GitBox <gi...@apache.org>.
junrao merged pull request #9393:
URL: https://github.com/apache/kafka/pull/9393
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao commented on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis
Posted by GitBox <gi...@apache.org>.
junrao commented on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705702092
In this PR, I have addressed the review comments from @chia7712 in #9001 which were provided after #9001 was merged. The changes are made mainly to KafkaAdminClient:
Improve error message in updateFeatures api when feature name is empty.
Propagate top-level error message in updateFeatures api.
Add an empty-parameter variety for describeFeatures api.
Minor documentation updates to @param and @return to make these resemble other apis.
Reviewers: Chia-Ping Tsai <ch...@gmail.com>, Jun Rao <ju...@gmail.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao removed a comment on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis
Posted by GitBox <gi...@apache.org>.
junrao removed a comment on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705702092
In this PR, I have addressed the review comments from @chia7712 in #9001 which were provided after #9001 was merged. The changes are made mainly to KafkaAdminClient:
Improve error message in updateFeatures api when feature name is empty.
Propagate top-level error message in updateFeatures api.
Add an empty-parameter variety for describeFeatures api.
Minor documentation updates to @param and @return to make these resemble other apis.
Reviewers: Chia-Ping Tsai <ch...@gmail.com>, Jun Rao <ju...@gmail.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705444078
@chia7712 thanks for the review! would you be able to please help merge this PR into trunk when CI passes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao merged pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis
Posted by GitBox <gi...@apache.org>.
junrao merged pull request #9393:
URL: https://github.com/apache/kafka/pull/9393
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org