You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "luoyuxia (via GitHub)" <gi...@apache.org> on 2026/02/08 11:29:46 UTC

[PR] ci: fix clippy warn error to long issue [paimon-rust]

luoyuxia opened a new pull request, #88:
URL: https://github.com/apache/paimon-rust/pull/88

   Fix issue #86 
   
   I'm going to contribute back some features to paimon-rust, but the ci won't work now. So, submit a pr to fix the ci as well as running `cargo clippy --all-targets --fix --allow-dirty --allow-staged` do some format.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: fix clippy warn error to long issue [paimon-rust]

Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on code in PR #88:
URL: https://github.com/apache/paimon-rust/pull/88#discussion_r2779162353


##########
crates/paimon/src/error.rs:
##########
@@ -40,7 +40,8 @@ pub enum Error {
     )]
     IoUnexpected {
         message: String,
-        source: opendal::Error,
+        #[snafu(source(from(opendal::Error, Box::new)))]
+        source: Box<opendal::Error>,

Review Comment:
   see https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
   which suggest us to wrap big size error to Box.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: fix clippy warn error to long issue [paimon-rust]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #88:
URL: https://github.com/apache/paimon-rust/pull/88#issuecomment-3888463231

   +1 Thanks @luoyuxia 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: fix clippy warn error to long issue [paimon-rust]

Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on PR #88:
URL: https://github.com/apache/paimon-rust/pull/88#issuecomment-3867037043

   cc @JingsongLi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: fix clippy warn error to long issue [paimon-rust]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #88:
URL: https://github.com/apache/paimon-rust/pull/88


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org