You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:34:02 UTC
[GitHub] [cordova-plugin-splashscreen] mosabab opened a new pull request #270: [Android] Add size specs for Splash Screens
mosabab opened a new pull request #270:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/270
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android.
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
Add size specs for Splash Screens.
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] mosabab commented on pull request #270: [Android] Add size specs for Splash Screens
Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #270:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/270#issuecomment-641208362
> Thank you for your PR.
>
> I was going to mimic some of the iOS documentation and have a `Android-specific Information` section with a table that describes the android sizes for splashscreens, similar to what we have for the iOS's [multi-image launch screen](https://github.com/apache/cordova-plugin-splashscreen#multi-image-launch-screen)
>
> Like so:
>
> size portrait landscape
> ldpi 200x320 320x200
> mdpi 320x480 480x320
> ... ... ...
> I think this makes it easier to link to (with an appropriate header), and makes the documentation a bit cleaner. What do you think?
I agree with you, because Android section for splash screen details not fit as well.
And also if you insert the details about `<preference name="SplashMaintainAspectRatio" value="true" />` after the table
Because it is useful and look better on screen if we use this preference.
Regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] mosabab edited a comment on pull request #270: [Android] Add size specs for Splash Screens
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #270:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/270#issuecomment-641208362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] breautek commented on pull request #270: [Android] Add size specs for Splash Screens
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #270:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/270#issuecomment-640970994
Thank you for your PR.
I was going to mimic some of the iOS documentation and have a `Android-specific Information` section with a table that describes the android sizes for splashscreens, similar to what we have for the iOS's [multi-image launch screen](https://github.com/apache/cordova-plugin-splashscreen#multi-image-launch-screen)
Like so:
| size | portrait | landscape
--------| ---------- | ----------
| ldpi | 200x320 | 320x200
| mdpi | 320x480 | 480x320
| ... | ... | ...
I think this makes it easier to link to (with an appropriate header), and makes the documentation a bit cleaner. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu closed pull request #270: [Android] Add size specs for Splash Screens
Posted by GitBox <gi...@apache.org>.
erisu closed pull request #270:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org