[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #1973: IGNITE-19225 Generate beginTs on a coordinator and send it to all tx participants

["SammyVimes (via GitHub)" <gi...@apache.org>]

SammyVimes commented on code in PR #1973:
URL: https://github.com/apache/ignite-3/pull/1973#discussion_r1176101449


##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/command/PartitionRaftCommandsSerializationTest.java:
##########
@@ -85,7 +85,7 @@ public void testUpdateCommand() throws Exception {
                         .partitionId(1)
                         .build()
                 )
-                .rowUuid(Timestamp.nextVersion().toUuid())
+                .rowUuid(TestTransactionIds.newTransactionId())
                 .rowBuffer(byteBufferFromBinaryRow(1))
                 .txId(UUID.randomUUID())

Review Comment:
   why `TestTransactionIds.newTransactionId()` not here but at `rowUuid`?



##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -352,7 +353,8 @@ public class IgniteImpl implements Ignite {
 
         ReplicaService replicaSvc = new ReplicaService(clusterSvc.messagingService(), clock);
 
-        txManager = new TxManagerImpl(replicaSvc, lockMgr, clock);
+        // TODO: IGNITE-19344 - use nodeId that is validated on join (and probably generated differently).
+        txManager = new TxManagerImpl(replicaSvc, lockMgr, clock, new TransactionIdGenerator(() -> clusterSvc.nodeName().hashCode()));

Review Comment:
   Why can't we use `nodeId` now?



##########
modules/transactions/src/testFixtures/java/org/apache/ignite/internal/tx/test/TestTransactionIds.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.tx.test;
+
+import java.util.UUID;
+import org.apache.ignite.internal.hlc.HybridClock;
+import org.apache.ignite.internal.hlc.HybridClockImpl;
+import org.apache.ignite.internal.tx.TransactionIds;
+
+/**
+ * Contains methods to generate transaction IDs for the cases when the clock and nodeId might be hard-coded
+ * (just for tests).
+ */
+public class TestTransactionIds {
+    /** Global clock instance. */
+    private static final HybridClock GLOBAL_CLOCK = new HybridClockImpl();
+
+    /** Hard-coded node ID. */
+    private static final int SOLE_NODE_ID = 0xdeadbeef;

Review Comment:
   Can you use `TransactionIdGenerator` here? This class feels like a copy of it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org