You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2023/01/10 09:41:48 UTC

[GitHub] [iotdb] ericpai commented on a diff in pull request #8786: [IOTDB-5370] Implement MultilevelPriorityQueue for query schedule

ericpai commented on code in PR #8786:
URL: https://github.com/apache/iotdb/pull/8786#discussion_r1065549535


##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/schedule/DriverTaskThread.java:
##########
@@ -44,17 +45,21 @@ public class DriverTaskThread extends AbstractDriverThread {
   private static final Executor listeningExecutor =
       IoTDBThreadPoolFactory.newCachedThreadPool("scheduler-notification");
 
+  private final Ticker ticker;
+
   public DriverTaskThread(
       String workerId,
       ThreadGroup tg,
       IndexedBlockingQueue<DriverTask> queue,
       ITaskScheduler scheduler,
       ThreadProducer producer) {
     super(workerId, tg, queue, scheduler, producer);
+    this.ticker = Ticker.systemTicker();

Review Comment:
   I don't know the real impaction between your usage and the one of official's suggestion.
   ![image](https://user-images.githubusercontent.com/3821212/211516243-73c1861b-d5bc-4ec8-a0fb-14de0629a98c.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org