[GitHub] [skywalking] hanahmily commented on issue #4144: Fix os maven plugin issues for Eclipse m2e

[GitBox <gi...@apache.org>]

hanahmily commented on issue #4144: Fix os maven plugin issues for Eclipse m2e
URL: https://github.com/apache/skywalking/pull/4144#issuecomment-569469410
 
 
   > Why do we pay attention on Eclipse now? Even no one maintain the compiling doc for eclipse.
   
   I'm switching my workspace from idea local development to vscode remote development(performance concerns and network issue), vscode uses m2e(eclipse plugin) to build java, so I should fix some compiling issues about it.
   
   > After reading the doc you referred, clearly there is a way rather than changing the project files. I highly prefer don't do this, as no committer or PMC will work on keeping things checked, and no way to verify this by CI.
   
   Yes, there's another way to do it. but if we merge this PR, other developers using Vscode and Eclipse will get benefits. And I will take care of those changes since I'm working with vscode.
   
   As you have reminded, the old way is from grpc-java official example, but my solution is also from mave-os-plugin official suggestion. I think if these changes passed CI test, we don't have any concerns about production release, especially our most committers are using idea as their ide, so if there's something wrong for the development environment, we will find it soon. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services