You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2009/12/14 16:20:18 UTC

[jira] Created: (LANG-565) Does StrSubstitutor really need setter methods for the fields that are settable via constructors?

Does StrSubstitutor really need setter methods for the fields that are settable via constructors?
-------------------------------------------------------------------------------------------------

                 Key: LANG-565
                 URL: https://issues.apache.org/jira/browse/LANG-565
             Project: Commons Lang
          Issue Type: Improvement
            Reporter: Sebb


Does StrSubstitutor really need setter methods for the fields that are settable via constructors?

If these setters could be dropped, the instance variables could be made final.

I think this would then make the class thread-safe, provided that the Map used by StrLookup is thread-safe.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (LANG-565) Does StrSubstitutor really need setter methods for the fields that are settable via constructors?

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-565.
------------------------------

    Resolution: Won't Fix

Closing as WONTFIX

> Does StrSubstitutor really need setter methods for the fields that are settable via constructors?
> -------------------------------------------------------------------------------------------------
>
>                 Key: LANG-565
>                 URL: https://issues.apache.org/jira/browse/LANG-565
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.text.*
>            Reporter: Sebb
>
> Does StrSubstitutor really need setter methods for the fields that are settable via constructors?
> If these setters could be dropped, the instance variables could be made final.
> I think this would then make the class thread-safe, provided that the Map used by StrLookup is thread-safe.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (LANG-565) Does StrSubstitutor really need setter methods for the fields that are settable via constructors?

Posted by "Stephen Colebourne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790481#action_12790481 ] 

Stephen Colebourne commented on LANG-565:
-----------------------------------------

We tend to have get/set to support bean-based tooling, as part of [lang]s mission to not be a framework.

I'm not sure being thread-safe helps StrSubstitutor as it is intended to be used from a singe thread.

> Does StrSubstitutor really need setter methods for the fields that are settable via constructors?
> -------------------------------------------------------------------------------------------------
>
>                 Key: LANG-565
>                 URL: https://issues.apache.org/jira/browse/LANG-565
>             Project: Commons Lang
>          Issue Type: Improvement
>            Reporter: Sebb
>
> Does StrSubstitutor really need setter methods for the fields that are settable via constructors?
> If these setters could be dropped, the instance variables could be made final.
> I think this would then make the class thread-safe, provided that the Map used by StrLookup is thread-safe.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (LANG-565) Does StrSubstitutor really need setter methods for the fields that are settable via constructors?

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795775#action_12795775 ] 

Henri Yandell commented on LANG-565:
------------------------------------

Even if used from multiple threads, I don't see StrSubstitutor being an object shared among multiple classes. Within the one class it's not that hard to use an object that doesn't demand thread safety in a thread safe way, and the setXxx methods are quite obviously going to hurt thread safety.

I suggest WONTFIX.

> Does StrSubstitutor really need setter methods for the fields that are settable via constructors?
> -------------------------------------------------------------------------------------------------
>
>                 Key: LANG-565
>                 URL: https://issues.apache.org/jira/browse/LANG-565
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.text.*
>            Reporter: Sebb
>
> Does StrSubstitutor really need setter methods for the fields that are settable via constructors?
> If these setters could be dropped, the instance variables could be made final.
> I think this would then make the class thread-safe, provided that the Map used by StrLookup is thread-safe.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.