[GitHub] [tinkerpop] jroimartin commented on a diff in pull request #1753: Gremlin-Go: Fixed bug for GHA, increased server wait retries & fixed traversal int casting

[GitBox <gi...@apache.org>]

jroimartin commented on code in PR #1753:
URL: https://github.com/apache/tinkerpop/pull/1753#discussion_r918465921


##########
gremlin-go/run.sh:
##########
@@ -44,7 +44,5 @@ GREMLIN_SERVER_VERSION=$(grep tinkerpop -A2 pom.xml | grep -Po '(?<=<version>)([
 export GREMLIN_SERVER="${1:-$GREMLIN_SERVER_VERSION}"
 echo "$GREMLIN_SERVER"
 
-# Passes current gremlin server version into docker compose as environment variable
-docker-compose up --build --exit-code-from gremlin-go-integration-tests
-# Removes all service containers
-docker-compose down
+# Passes current gremlin server version into docker compose as environment variable & removes all service containers
+docker-compose up --build --abort-on-container-exit --exit-code-from gremlin-go-integration-tests && docker-compose down

Review Comment:
   Do we really need `docker-compose down` if we abort on container exit?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org