You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/11 12:51:05 UTC
[GitHub] [iotdb-web-workbench] JulianFeinauer opened a new pull request #4: Haungrui777/master
JulianFeinauer opened a new pull request #4:
URL: https://github.com/apache/iotdb-web-workbench/pull/4
This is a PR that extends #2 with some adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] JulianFeinauer merged pull request #4: Haungrui777/master
Posted by GitBox <gi...@apache.org>.
JulianFeinauer merged pull request #4:
URL: https://github.com/apache/iotdb-web-workbench/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] JulianFeinauer commented on pull request #4: Haungrui777/master
Posted by GitBox <gi...@apache.org>.
JulianFeinauer commented on pull request #4:
URL: https://github.com/apache/iotdb-web-workbench/pull/4#issuecomment-923004904
Will merge that now. Big thanks to @haungrui777 and @NiklasMerz ! 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] JulianFeinauer commented on pull request #4: Haungrui777/master
Posted by GitBox <gi...@apache.org>.
JulianFeinauer commented on pull request #4:
URL: https://github.com/apache/iotdb-web-workbench/pull/4#issuecomment-922457465
Thanks @haungrui777 and regarding your question @NiklasMerz there are still issues in the lint-css phase but I woild be fine in deactivating it for now so that we have a green Branch before merging. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] haungrui777 commented on pull request #4: Haungrui777/master
Posted by GitBox <gi...@apache.org>.
haungrui777 commented on pull request #4:
URL: https://github.com/apache/iotdb-web-workbench/pull/4#issuecomment-919022184
> @haungrui777 could you have a look at the failing lint-css command in the build? I think we can easily merge it when this is fixed.
fixed the css lint error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] NiklasMerz commented on pull request #4: Haungrui777/master
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #4:
URL: https://github.com/apache/iotdb-web-workbench/pull/4#issuecomment-922653641
Check out this PR for your branch: https://github.com/JulianFeinauer/iotdb-web-workbench/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] NiklasMerz edited a comment on pull request #4: Haungrui777/master
Posted by GitBox <gi...@apache.org>.
NiklasMerz edited a comment on pull request #4:
URL: https://github.com/apache/iotdb-web-workbench/pull/4#issuecomment-919874299
@JulianFeinauer Are we now ready to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] JulianFeinauer commented on pull request #4: Haungrui777/master
Posted by GitBox <gi...@apache.org>.
JulianFeinauer commented on pull request #4:
URL: https://github.com/apache/iotdb-web-workbench/pull/4#issuecomment-917449665
@haungrui777 could you have a look at the failing lint-css command in the build? I think we can easily merge it when this is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-web-workbench] NiklasMerz commented on pull request #4: Haungrui777/master
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #4:
URL: https://github.com/apache/iotdb-web-workbench/pull/4#issuecomment-919874299
@JulianFeinauer Are we not ready to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org