DO NOT REPLY [Bug 42398] New: - Suggestion for clarification in UpdateManager.interrupt comment

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42398>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42398

           Summary: Suggestion for clarification in UpdateManager.interrupt
                    comment
           Product: Batik
           Version: 1.7
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: trivial
          Priority: P5
         Component: Bridge
        AssignedTo: batik-dev@xmlgraphics.apache.org
        ReportedBy: Jeff.Grigg@asolutions.com


A suggestion for additional information that could be included to explain the
empty catch clause in the UpdateManager.interrupt comment:

// An IllegalStateException can be thrown by the RunnableQueue.resumeExecution()
method, due to a race condition:  The RunnableQueue.preemptLater method call
starts the process of killing the RunnableQueue thread, which could finish
before the resumeExecution method is called.  Additional synchronization might
fix this, but it's easy and effective to discard the redundant exception.


(I ran into this while tracking real IllegalStateException cases caused by our
code.  It took a little research to determine that this IllegalStateException is
NOT a problem.  So it might save other developers some confusion and effort if
additional comments were present.)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org