You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/04/14 14:54:58 UTC
Review Request 58457: RANGER-1516 - Remove remaining
*-plugin-install.properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58457/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1516
https://issues.apache.org/jira/browse/RANGER-1516
Repository: ranger
Description
-------
RANGER-1457 removed the yarn-plugin-install.properties. We should do the same for the two remaining plugins that use them, namely Kafka + Solr. They are redundant in both cases, as the COMPONENT_INSTALL_DIR_NAME is already in install.properties.
Diffs
-----
plugin-kafka/scripts/kafka-plugin-install.properties 4f64c62
plugin-solr/scripts/solr-plugin-install.properties c040949
src/main/assembly/plugin-kafka.xml 86777a9
src/main/assembly/plugin-solr.xml a453a9b
Diff: https://reviews.apache.org/r/58457/diff/1/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 58457: RANGER-1516 - Remove remaining
*-plugin-install.properties
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58457/#review172058
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On \u56db\u6708 14, 2017, 2:54 p.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58457/
> -----------------------------------------------------------
>
> (Updated \u56db\u6708 14, 2017, 2:54 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1516
> https://issues.apache.org/jira/browse/RANGER-1516
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1457 removed the yarn-plugin-install.properties. We should do the same for the two remaining plugins that use them, namely Kafka + Solr. They are redundant in both cases, as the COMPONENT_INSTALL_DIR_NAME is already in install.properties.
>
>
> Diffs
> -----
>
> plugin-kafka/scripts/kafka-plugin-install.properties 4f64c62
> plugin-solr/scripts/solr-plugin-install.properties c040949
> src/main/assembly/plugin-kafka.xml 86777a9
> src/main/assembly/plugin-solr.xml a453a9b
>
>
> Diff: https://reviews.apache.org/r/58457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>