[jira] Commented: (HARMONY-1941) [drlvm][ipf] implementation and support for new code layoting algorithm

["Egor Pasko (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/HARMONY-1941?page=comments#action_12444779 ] 
            
Egor Pasko commented on HARMONY-1941:
-------------------------------------

I reviewed the patch. Looks great! Some TODOs fixed, the code looks cleaner, etc.
This patch does not affect IA-32 (only IPF files, and I checked it formally on Linux), so, I am eager for committing it!
(a tiny suggestion: try <= 80 chars per line:)

> [drlvm][ipf] implementation and support for new code layoting algorithm
> -----------------------------------------------------------------------
>
>                 Key: HARMONY-1941
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1941
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Konstantin Anisimov
>         Attachments: code_layouter__ipf.txt
>
>
> IpfCfg.h, IpfCfg.cpp
>    methods added in Edge and Node classes to support new layouting
> IpfCodeLayouter.h, IpfCodeLayouter.cpp:
>    new BotomUp algorithm implementation
> IpfEmitter.h, IpfEmitter.cpp
>    minor changes in logging, Emitter::registerDirectCall() and debugging support
> IpfIrPrinter.h, IpfIrPrinter.cpp
>    added method to print Node chains
> IpfType.h
>    types to support Node chains added
> IpfCfgVerifier.cpp
>    method cfg.getArgs() deprecated
> IpfInst.cpp
>    methods to identify inst kind added (isBr, isCall ...)
> IpfRegisterAllocator.cpp
>    minor changes in logging

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira