You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sourabh Goyal (Code Review)" <ge...@cloudera.org> on 2022/02/10 18:52:07 UTC
[Impala-ASF-CR] IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
Sourabh Goyal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18221
Change subject: IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
......................................................................
IMPALA-10648 addendum: Handle null return value from catalog's
renameTable() api
CatalogServiceCatalog.renameTable(oldTable, newTable) api
sometimes return null if oldTable's db does not exist
in cache. The caller of this api should check for null
return value.
Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
---
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/18221/1
--
To view, visit http://gerrit.cloudera.org:8080/18221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
Gerrit-Change-Number: 18221
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
[Impala-ASF-CR] IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
Posted by "Sourabh Goyal (Code Review)" <ge...@cloudera.org>.
Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/18221 )
Change subject: IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
......................................................................
Patch Set 1:
Please review and share your feedback
--
To view, visit http://gerrit.cloudera.org:8080/18221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
Gerrit-Change-Number: 18221
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 18:54:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18221 )
Change subject: IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10136/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
Gerrit-Change-Number: 18221
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 19:14:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18221 )
Change subject: IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
Gerrit-Change-Number: 18221
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 07:30:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18221 )
Change subject: IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
Gerrit-Change-Number: 18221
Gerrit-PatchSet: 2
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 07:31:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18221 )
Change subject: IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
Gerrit-Change-Number: 18221
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 18:59:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18221 )
Change subject: IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
Gerrit-Change-Number: 18221
Gerrit-PatchSet: 2
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 14:05:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18221 )
Change subject: IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
......................................................................
IMPALA-10648 addendum: Handle null return value from catalog's
renameTable() api
CatalogServiceCatalog.renameTable(oldTable, newTable) api
sometimes return null if oldTable's db does not exist
in cache. The caller of this api should check for null
return value.
Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
Reviewed-on: http://gerrit.cloudera.org:8080/18221
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
Gerrit-Change-Number: 18221
Gerrit-PatchSet: 3
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
[Impala-ASF-CR] IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18221 )
Change subject: IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7831/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
Gerrit-Change-Number: 18221
Gerrit-PatchSet: 2
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 07:31:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18221 )
Change subject: IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7829/
--
To view, visit http://gerrit.cloudera.org:8080/18221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
Gerrit-Change-Number: 18221
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 02:07:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18221 )
Change subject: IMPALA-10648 addendum: Handle null return value from catalog's renameTable() api
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7829/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3661b351cad16ead22608dcef33789f0ba2fb6f
Gerrit-Change-Number: 18221
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 18:56:44 +0000
Gerrit-HasComments: No