You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/06/19 19:38:01 UTC
Review Request: Fix broken build on GCC 4.8 due to -Wall.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11974/
-----------------------------------------------------------
Review request for mesos.
Description
-------
Fix broken build on GCC 4.8 due to -Wall.
With GCC 4.8, Boost fails to build from '-Wunused-local-typedefs', which
is implied by '-Wall'.
Diffs
-----
configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e
Diff: https://reviews.apache.org/r/11974/diff/
Testing
-------
make check
Thanks,
Brenden Matthews
Re: Review Request 11974: Fix broken build on GCC 4.8 due to -Wall.
Posted by Yong Fu <la...@gmail.com>.
> On Sept. 13, 2013, 9:19 p.m., Ben Mahler wrote:
> > Can you update the comment with the fact that 1.54 also doesn't compile? :(
> >
> > Just curious, was this the only obstacle to compiling with gcc 4.8? Otherwise maybe it's best to bundle all the needed fixes in one review?
Tried it. Doesn't work.
https://issues.apache.org/jira/browse/MESOS-688
This is the only problem I ran into to build with gcc 4.8.
- Yong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11974/#review26100
-----------------------------------------------------------
On June 26, 2013, 8:42 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11974/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 8:42 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix broken build on GCC 4.8 due to -Wall.
>
> With GCC 4.8, Boost fails to build from '-Wunused-local-typedefs', which
> is implied by '-Wall'.
>
> Review: https://reviews.apache.org/r/11974/
>
>
> Diffs
> -----
>
> configure.ac fbe22e5772502ef3d9bea7b58b323881a51934ab
>
> Diff: https://reviews.apache.org/r/11974/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 11974: Fix broken build on GCC 4.8 due to -Wall.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11974/#review26100
-----------------------------------------------------------
Ship it!
Can you update the comment with the fact that 1.54 also doesn't compile? :(
Just curious, was this the only obstacle to compiling with gcc 4.8? Otherwise maybe it's best to bundle all the needed fixes in one review?
- Ben Mahler
On June 26, 2013, 8:42 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11974/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 8:42 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix broken build on GCC 4.8 due to -Wall.
>
> With GCC 4.8, Boost fails to build from '-Wunused-local-typedefs', which
> is implied by '-Wall'.
>
> Review: https://reviews.apache.org/r/11974/
>
>
> Diffs
> -----
>
> configure.ac fbe22e5772502ef3d9bea7b58b323881a51934ab
>
> Diff: https://reviews.apache.org/r/11974/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 11974: Fix broken build on GCC 4.8 due to -Wall.
Posted by Brenden Matthews <br...@diddyinc.com>.
> On June 27, 2013, 12:15 a.m., Ben Mahler wrote:
> > configure.ac, lines 54-60
> > <https://reviews.apache.org/r/11974/diff/2/?file=311248#file311248line54>
> >
> > Looks like boost 1.54.0 will be released on Monday, which might have fully fixed the issue anyway:
> >
> > http://www.boost.org/development/index.html
> > https://svn.boost.org/trac/boost/ticket/7242
> > https://svn.boost.org/trac/boost/ticket/8546
> >
> > willing to wait and try upgrading Boost before we commit this?
That's reasonable. We'll hold off till then.
- Brenden
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11974/#review22448
-----------------------------------------------------------
On June 26, 2013, 8:42 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11974/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 8:42 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix broken build on GCC 4.8 due to -Wall.
>
> With GCC 4.8, Boost fails to build from '-Wunused-local-typedefs', which
> is implied by '-Wall'.
>
> Review: https://reviews.apache.org/r/11974/
>
>
> Diffs
> -----
>
> configure.ac fbe22e5772502ef3d9bea7b58b323881a51934ab
>
> Diff: https://reviews.apache.org/r/11974/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 11974: Fix broken build on GCC 4.8 due to -Wall.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11974/#review22448
-----------------------------------------------------------
configure.ac
<https://reviews.apache.org/r/11974/#comment45999>
Looks like boost 1.54.0 will be released on Monday, which might have fully fixed the issue anyway:
http://www.boost.org/development/index.html
https://svn.boost.org/trac/boost/ticket/7242
https://svn.boost.org/trac/boost/ticket/8546
willing to wait and try upgrading Boost before we commit this?
- Ben Mahler
On June 26, 2013, 8:42 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11974/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 8:42 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix broken build on GCC 4.8 due to -Wall.
>
> With GCC 4.8, Boost fails to build from '-Wunused-local-typedefs', which
> is implied by '-Wall'.
>
> Review: https://reviews.apache.org/r/11974/
>
>
> Diffs
> -----
>
> configure.ac fbe22e5772502ef3d9bea7b58b323881a51934ab
>
> Diff: https://reviews.apache.org/r/11974/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 11974: Fix broken build on GCC 4.8 due to -Wall.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11974/
-----------------------------------------------------------
(Updated June 26, 2013, 8:42 p.m.)
Review request for mesos.
Changes
-------
Updated as per Ben's comments.
Repository: mesos
Description (updated)
-------
Fix broken build on GCC 4.8 due to -Wall.
With GCC 4.8, Boost fails to build from '-Wunused-local-typedefs', which
is implied by '-Wall'.
Review: https://reviews.apache.org/r/11974/
Diffs (updated)
-----
configure.ac fbe22e5772502ef3d9bea7b58b323881a51934ab
Diff: https://reviews.apache.org/r/11974/diff/
Testing
-------
make check
Thanks,
Brenden Matthews
Re: Review Request 11974: Fix broken build on GCC 4.8 due to -Wall.
Posted by Brenden Matthews <br...@diddyinc.com>.
> On June 20, 2013, 3:58 a.m., Ben Mahler wrote:
> > Are there stock OS's shipping with GCC 4.8?
Debian sid has it. Presumably others do too (Fedora?). It's been out since March.
- Brenden
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11974/#review22144
-----------------------------------------------------------
On June 19, 2013, 5:38 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11974/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 5:38 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix broken build on GCC 4.8 due to -Wall.
>
> With GCC 4.8, Boost fails to build from '-Wunused-local-typedefs', which
> is implied by '-Wall'.
>
>
> Diffs
> -----
>
> configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e
>
> Diff: https://reviews.apache.org/r/11974/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Fix broken build on GCC 4.8 due to -Wall.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11974/#review22144
-----------------------------------------------------------
Are there stock OS's shipping with GCC 4.8?
configure.ac
<https://reviews.apache.org/r/11974/#comment45557>
Can you make this a TODO, mentioning the boost version that we know has an issue?
- Ben Mahler
On June 19, 2013, 5:38 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11974/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 5:38 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Fix broken build on GCC 4.8 due to -Wall.
>
> With GCC 4.8, Boost fails to build from '-Wunused-local-typedefs', which
> is implied by '-Wall'.
>
>
> Diffs
> -----
>
> configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e
>
> Diff: https://reviews.apache.org/r/11974/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>