You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Bas Bosman (JIRA)" <ji...@apache.org> on 2014/05/11 00:05:13 UTC

[jira] [Commented] (CB-6643) Missing input param in ConfigParser.js

    [ https://issues.apache.org/jira/browse/CB-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994236#comment-13994236 ] 

Bas Bosman commented on CB-6643:
--------------------------------

Pull request:
https://github.com/apache/cordova-lib/pull/3

> Missing input param in ConfigParser.js
> --------------------------------------
>
>                 Key: CB-6643
>                 URL: https://issues.apache.org/jira/browse/CB-6643
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 3.4.0
>         Environment: Ubuntu x86 13.10
>            Reporter: Adam Fónagy
>            Assignee: Bas Bosman
>              Labels: javascript, parameter, platform, ubuntu
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> when type cordova platform add ubuntu you get the following error:
> ReferenceError: name is not defined
>     at Object.ConfigParser.setDescription (/usr/local/lib/node_modules/cordova/src/ConfigParser.js:70:45)
>     at Object.module.exports.update_from_config (/usr/local/lib/node_modules/cordova/src/metadata/ubuntu_parser.js:74:21)
>     at Object.module.exports.update_project (/usr/local/lib/node_modules/cordova/src/metadata/ubuntu_parser.js:156:21)
>     at /usr/local/lib/node_modules/cordova/src/prepare.js:113:31
>     at _fulfilled (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:798:54)
>     at self.promiseDispatch.done (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:827:30)
>     at Promise.promise.promiseDispatch (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:760:13)
>     at /usr/local/lib/node_modules/cordova/node_modules/q/q.js:821:14
>     at flush (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:108:17)
>     at process._tickCallback (node.js:415:13)
> This is because in ConfigParser.js at line 69 the input parameter is missing. This is how the function looks like in Cordova 3.4.0:
> setDescription: function() {
>         this.doc.find('description').text = name;
>         var el = findOrCreate(this.doc, 'description');
>     },
> And this is how it should:
> setDescription: function(name) {
>         this.doc.find('description').text = name;
>         var el = findOrCreate(this.doc, 'description');
>     },



--
This message was sent by Atlassian JIRA
(v6.2#6252)