You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2026/09/18 05:52:25 UTC

[PR] docs(design): correct tag-aggregation design doc after #14089's review cycle [skywalking-banyandb]

hanahmily opened a new pull request, #1363:
URL: https://github.com/apache/skywalking-banyandb/pull/1363

   ## Summary
   
   Implementing and reviewing time-bucket grouping (apache/skywalking#14089, #1362) surfaced three places where the merged [tag aggregation and time bucketing design](docs/design/0.12.0/tag-aggregation/README.md) (#1360) no longer matches what actually shipped:
   
   - **§7.5** claimed liaison-merge and index-mode ordering were bucket-ascending "by construction," same as the node-local streaming case. Both actually need an explicit sort (`BatchAggregation.SortInsertionByBucket`), added in #1362 after two review rounds found the gap. Node-local ordering is still free; the doc now says which case is which, and flags that COUNT_DISTINCT's distributed reduce (§7.4, apache/skywalking#14090) shares this same reduce path and must not re-introduce the false assumption.
   - **§7.2**'s "relaxes to a pipelined operator" undersold the actual change: a `BreakerOperator` cannot be pipelined by relaxation, since `breakerStage`'s contract fully drains upstream before serving output. The doc now names the real fix (`BatchTimeBucket` as a genuine `PullOperator`, spliced in via a new `PipelineBuilder.Transform` primitive) and the follow-up fix for map-mode's terminal aggregator (`drainMapModeAggregator`), both discovered during review.
   - **§3** never stated whether `group_by.time_bucket` requires `agg`. It does, for a concrete reason found during implementation (the no-`agg` shape doesn't preserve the full output schema) — recorded as a current limitation, not a permanent decision.
   
   No behavior change — the shipped code already reflects all three corrections. This is a documentation-only PR to keep the design doc accurate for whoever picks up apache/skywalking#14090 (COUNT_DISTINCT) and apache/skywalking#14091 (BydbQL) next.
   
   ## Test plan
   
   - Docs-only change; no code affected.
   - Verified the patch applies cleanly on top of `main` (post-#1362) and section numbering/headers remain consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs(design): correct tag-aggregation design doc after #14089's review cycle [skywalking-banyandb]

Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on PR #1363:
URL: https://github.com/apache/skywalking-banyandb/pull/1363#issuecomment-5725828750

   Folding this into the #14090 implementation branch instead of shipping it standalone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs(design): correct tag-aggregation design doc after #14089's review cycle [skywalking-banyandb]

Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily closed pull request #1363: docs(design): correct tag-aggregation design doc after #14089's review cycle
URL: https://github.com/apache/skywalking-banyandb/pull/1363


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org