You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/31 20:41:19 UTC

[GitHub] [airflow] augusto-herrmann commented on issue #19264: TriggerDagRunOperator External Link doesn't link with execution date to match to triggered DAG

augusto-herrmann commented on issue #19264:
URL: https://github.com/apache/airflow/issues/19264#issuecomment-1233400217

   By the way, since [`execution_date` has been renamed to `logical_date`](https://airflow.apache.org/docs/apache-airflow/stable/faq.html#faq-what-does-execution-date-mean), but `TriggerDagRunOperator` [still uses this nomenclature](https://airflow.apache.org/docs/apache-airflow/stable/_api/airflow/operators/trigger_dagrun/index.html#airflow.operators.trigger_dagrun.TriggerDagRunOperator), shouldn't this be changed? Like so:
   * rename the `execution_date` parameter to `logical_date`
   * using the `execution_date` parameter in this class would call `logical_date` for backward compatibility, after raising a deprecation warning
   
   If this makes sense, I can create a new issue about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org