You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/11/19 17:41:39 UTC
[jira] Created: (CASSANDRA-563) expose TimeoutException to Thrift
expose TimeoutException to Thrift
---------------------------------
Key: CASSANDRA-563
URL: https://issues.apache.org/jira/browse/CASSANDRA-563
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Minor
Fix For: 0.5
Turning TimeoutException into UnavailableException is confusing to users. Let's expose that directly to make it clear that your options are (1) increase the timeout, (2) retry the op if cassandra was temporarily too busy, or (3) split the op up into smaller chunks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-563) expose TimeoutException to Thrift
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780168#action_12780168 ]
Gary Dusbabek commented on CASSANDRA-563:
-----------------------------------------
In general is it cool to catch EX and rethrow a EY without calling EY.initCause(EX)? Otherwise, +1.
> expose TimeoutException to Thrift
> ---------------------------------
>
> Key: CASSANDRA-563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-563
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 563.patch
>
>
> Turning TimeoutException into UnavailableException is confusing to users. Let's expose that directly to make it clear that your options are (1) increase the timeout, (2) retry the op if cassandra was temporarily too busy, or (3) split the op up into smaller chunks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-563) expose TimeoutException to Thrift
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780537#action_12780537 ]
Hudson commented on CASSANDRA-563:
----------------------------------
Integrated in Cassandra #264 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/264/])
expose TimedOutException distinct from UnavailableException
patch by jbellis; reviewed by gdusbabek for
> expose TimeoutException to Thrift
> ---------------------------------
>
> Key: CASSANDRA-563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-563
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 563.patch
>
>
> Turning TimeoutException into UnavailableException is confusing to users. Let's expose that directly to make it clear that your options are (1) increase the timeout, (2) retry the op if cassandra was temporarily too busy, or (3) split the op up into smaller chunks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-563) expose TimeoutException to Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-563:
-------------------------------------
Attachment: 563.patch
(most of the diff here is generated thrift, look at the parts outside gen-java for the "real" patch.)
> expose TimeoutException to Thrift
> ---------------------------------
>
> Key: CASSANDRA-563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-563
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 563.patch
>
>
> Turning TimeoutException into UnavailableException is confusing to users. Let's expose that directly to make it clear that your options are (1) increase the timeout, (2) retry the op if cassandra was temporarily too busy, or (3) split the op up into smaller chunks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-563) expose TimeoutException to Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780203#action_12780203 ]
Jonathan Ellis commented on CASSANDRA-563:
------------------------------------------
I don't think we have a choice, unless you know of a way to get Thrift to generate a constructor that takes a Java exception.
> expose TimeoutException to Thrift
> ---------------------------------
>
> Key: CASSANDRA-563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-563
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 563.patch
>
>
> Turning TimeoutException into UnavailableException is confusing to users. Let's expose that directly to make it clear that your options are (1) increase the timeout, (2) retry the op if cassandra was temporarily too busy, or (3) split the op up into smaller chunks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-563) expose TimeoutException to Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-563.
--------------------------------------
Resolution: Fixed
committed
> expose TimeoutException to Thrift
> ---------------------------------
>
> Key: CASSANDRA-563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-563
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 563.patch
>
>
> Turning TimeoutException into UnavailableException is confusing to users. Let's expose that directly to make it clear that your options are (1) increase the timeout, (2) retry the op if cassandra was temporarily too busy, or (3) split the op up into smaller chunks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.