[GitHub] [zeppelin] zjffdu commented on a change in pull request #3434: [ZEPPELIN-4281] Fixed unusable after cluster mode restarts interpreter

[GitBox <gi...@apache.org>]

zjffdu commented on a change in pull request #3434: [ZEPPELIN-4281] Fixed unusable after cluster mode restarts interpreter
URL: https://github.com/apache/zeppelin/pull/3434#discussion_r319715971
 
 

 ##########
 File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
 ##########
 @@ -238,6 +239,9 @@ public void run() {
   @Override
   public void shutdown() throws TException {
     logger.info("Shutting down...");
+    // delete interpreter cluster meta
+    deleteClusterMeta();
 
 Review comment:
   What happens if interpreter process is killed manually (e.g. via kill -9, or killed by yarn) in which case shutdown is not called. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services