You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "urosstan-db (via GitHub)" <gi...@apache.org> on 2025/07/09 08:20:30 UTC
[PR] [SPARK-52722] Deprecate JdbcRDD class [spark]
urosstan-db opened a new pull request, #51415:
URL: https://github.com/apache/spark/pull/51415
`JdbcRDD` is legacy way to integrate Spark with JDBC sources.
Instead of it, users should use newer and more powerful JDBC data source.
### What changes were proposed in this pull request?
- Deprecating `JdbcRDD`
### Why are the changes needed?
`JdbcRDD` is legacy feature not being used a lot anymore and it raises confusion because there are similar class called `JDBCRDD` that comes from the JDBC connector.
### Does this PR introduce _any_ user-facing change?
`JdbcRDD` is deprecated now. JDBC data source (connector) is more modern and more powerful way to connect to the JDBC source.
### How was this patch tested?
No testing needed, adding Java annotation to the class.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52722] Deprecate JdbcRDD class [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #51415:
URL: https://github.com/apache/spark/pull/51415#issuecomment-3051751736
Can we also replace `JdbcRDD` with `JDBCRDD` for internal usages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52722] Deprecate JdbcRDD class [spark]
Posted by "urosstan-db (via GitHub)" <gi...@apache.org>.
urosstan-db commented on PR #51415:
URL: https://github.com/apache/spark/pull/51415#issuecomment-3051762819
> Can we also replace `JdbcRDD` with `JDBCRDD` for internal usages?
Yes, I did not found any internal reference for `JdbcRDD` except in the [suite](https://github.com/apache/spark/blob/master/core/src/test/java/org/apache/spark/JavaJdbcRDDSuite.java).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52722][CORE] Deprecate JdbcRDD class [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #51415:
URL: https://github.com/apache/spark/pull/51415#issuecomment-3064942389
Merged into master for Apache Spark 4.1.0. Thanks @urosstan-db and all ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52722] Deprecate JdbcRDD class [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #51415:
URL: https://github.com/apache/spark/pull/51415#discussion_r2195063945
##########
core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala:
##########
@@ -55,6 +55,7 @@ private[spark] class JdbcPartition(idx: Int, val lower: Long, val upper: Long) e
* This should only call getInt, getString, etc; the RDD takes care of calling next.
* The default maps a ResultSet to an array of Object.
*/
+@deprecated("Jdbc RDD is deprecated, consider using JDBC data source instead.")
Review Comment:
```suggestion
@deprecated("Jdbc RDD is deprecated, consider using JDBC data source instead.", "4.1.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52722][CORE] Deprecate JdbcRDD class [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #51415: [SPARK-52722][CORE] Deprecate JdbcRDD class
URL: https://github.com/apache/spark/pull/51415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org