You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2019/05/11 07:27:12 UTC
[maven-resolver] 01/03: [MRESOLVER-88] Checkstyle cleanup -
MagicNumber
This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch MRESOLVER-88
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git
commit 439f619a5dc60897ab2c70f1b42689854b19715a
Author: Sylwester Lachiewicz <sl...@apache.org>
AuthorDate: Thu Apr 25 08:32:36 2019 +0200
[MRESOLVER-88] Checkstyle cleanup - MagicNumber
---
.../main/java/org/eclipse/aether/DefaultRepositorySystemSession.java | 1 +
.../main/java/org/eclipse/aether/repository/AuthenticationDigest.java | 2 ++
.../apache/maven/resolver/examples/util/ConsoleTransferListener.java | 1 +
.../org/eclipse/aether/internal/impl/DefaultUpdatePolicyAnalyzer.java | 2 ++
.../src/main/java/org/eclipse/aether/internal/impl/SimpleDigest.java | 1 +
.../java/org/eclipse/aether/internal/impl/TrackingFileManager.java | 1 +
.../main/java/org/eclipse/aether/internal/impl/collect/NodeStack.java | 3 +++
.../main/java/org/eclipse/aether/internal/impl/collect/Results.java | 1 +
.../src/main/java/org/eclipse/aether/transport/http/GlobalState.java | 1 +
.../main/java/org/eclipse/aether/transport/http/HttpTransporter.java | 3 +++
.../main/java/org/eclipse/aether/transport/http/SharingAuthCache.java | 1 +
.../src/main/java/org/eclipse/aether/util/ChecksumUtils.java | 1 +
.../src/main/java/org/eclipse/aether/util/graph/visitor/Stack.java | 2 ++
.../java/org/eclipse/aether/util/repository/SecretAuthentication.java | 1 +
.../main/java/org/eclipse/aether/util/version/UnionVersionRange.java | 1 +
pom.xml | 2 +-
16 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java b/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
index b93ebe5..b2c05cd 100644
--- a/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
+++ b/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
@@ -400,6 +400,7 @@ public final class DefaultRepositorySystemSession
return this;
}
+ @SuppressWarnings( "checkstyle:magicnumber" )
private <T> Map<String, T> copySafe( Map<?, ?> table, Class<T> valueType )
{
Map<String, T> map;
diff --git a/maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationDigest.java b/maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationDigest.java
index e186060..27b88c0 100644
--- a/maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationDigest.java
+++ b/maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationDigest.java
@@ -168,6 +168,7 @@ public final class AuthenticationDigest
*
* @param chars The characters to update the digest with, may be {@code null}.
*/
+ @SuppressWarnings( "checkstyle:magicnumber" )
public void update( char... chars )
{
if ( chars != null )
@@ -193,6 +194,7 @@ public final class AuthenticationDigest
}
}
+ @SuppressWarnings( "checkstyle:magicnumber" )
private String digest()
{
byte[] bytes = digest.digest();
diff --git a/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ConsoleTransferListener.java b/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ConsoleTransferListener.java
index e52034a..bba92d8 100644
--- a/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ConsoleTransferListener.java
+++ b/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ConsoleTransferListener.java
@@ -170,6 +170,7 @@ public class ConsoleTransferListener
event.getException().printStackTrace( out );
}
+ @SuppressWarnings( "checkstyle:magicnumber" )
protected long toKB( long bytes )
{
return ( bytes + 1023 ) / 1024;
diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdatePolicyAnalyzer.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdatePolicyAnalyzer.java
index 51981cc..3ef336c 100644
--- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdatePolicyAnalyzer.java
+++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdatePolicyAnalyzer.java
@@ -48,6 +48,7 @@ public class DefaultUpdatePolicyAnalyzer
return ordinalOfUpdatePolicy( policy1 ) < ordinalOfUpdatePolicy( policy2 ) ? policy1 : policy2;
}
+ @SuppressWarnings( { "checkstyle:magicnumber" } )
private int ordinalOfUpdatePolicy( String policy )
{
if ( RepositoryPolicy.UPDATE_POLICY_DAILY.equals( policy ) )
@@ -116,6 +117,7 @@ public class DefaultUpdatePolicyAnalyzer
return checkForUpdates;
}
+ @SuppressWarnings( { "checkstyle:magicnumber" } )
private int getMinutes( String policy )
{
int minutes;
diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SimpleDigest.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SimpleDigest.java
index a5d55f5..479ae76 100644
--- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SimpleDigest.java
+++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SimpleDigest.java
@@ -69,6 +69,7 @@ class SimpleDigest
}
}
+ @SuppressWarnings( "checkstyle:magicnumber" )
public String digest()
{
if ( digest != null )
diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
index e377065..031f218 100644
--- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
+++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
@@ -194,6 +194,7 @@ class TrackingFileManager
}
}
+ @SuppressWarnings( { "checkstyle:magicnumber" } )
private FileLock lock( FileChannel channel, long size, boolean shared )
throws IOException
{
diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/NodeStack.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/NodeStack.java
index a7cbc78..668dbc4 100644
--- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/NodeStack.java
+++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/NodeStack.java
@@ -30,7 +30,10 @@ import org.eclipse.aether.graph.DependencyNode;
final class NodeStack
{
+ @SuppressWarnings( {"unchecked", "checkstyle:magicnumber" } )
+ // CHECKSTYLE_OFF: MagicNumber
private DependencyNode[] nodes = new DependencyNode[96];
+ // CHECKSTYLE_ON: MagicNumber
private int size;
diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/Results.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/Results.java
index 2d27c9d..27d6121 100644
--- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/Results.java
+++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/Results.java
@@ -35,6 +35,7 @@ class Results
String errorPath;
+ @SuppressWarnings( { "checkstyle:magicnumber" } )
Results( CollectResult result, RepositorySystemSession session )
{
this.result = result;
diff --git a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/GlobalState.java b/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/GlobalState.java
index 9244beb..29ef555 100644
--- a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/GlobalState.java
+++ b/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/GlobalState.java
@@ -169,6 +169,7 @@ final class GlobalState
return manager;
}
+ @SuppressWarnings( "checkstyle:magicnumber" )
public static ClientConnectionManager newConnectionManager( SslConfig sslConfig )
{
SchemeRegistry schemeReg = new SchemeRegistry();
diff --git a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java b/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java
index 8d357d0..15fa36a 100644
--- a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java
+++ b/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java
@@ -340,6 +340,7 @@ final class HttpTransporter
return response.containsHeader( HttpHeaders.DAV );
}
+ @SuppressWarnings( "checkstyle:magicnumber" )
private void mkdirs( URI uri, SharingHttpContext context )
{
List<URI> dirs = UriUtils.getDirectories( baseUri, uri );
@@ -447,6 +448,7 @@ final class HttpTransporter
return request;
}
+ @SuppressWarnings( "checkstyle:magicnumber" )
private <T extends HttpUriRequest> T resume( T request, GetTask task )
{
long resumeOffset = task.getResumeOffset();
@@ -460,6 +462,7 @@ final class HttpTransporter
return request;
}
+ @SuppressWarnings( "checkstyle:magicnumber" )
private void handleStatus( HttpResponse response )
throws HttpResponseException
{
diff --git a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/SharingAuthCache.java b/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/SharingAuthCache.java
index 8835bad..fcea8ae 100644
--- a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/SharingAuthCache.java
+++ b/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/SharingAuthCache.java
@@ -44,6 +44,7 @@ final class SharingAuthCache
authSchemes = new HashMap<>();
}
+ @SuppressWarnings( "checkstyle:magicnumber" )
private static HttpHost toKey( HttpHost host )
{
if ( host.getPort() <= 0 )
diff --git a/maven-resolver-util/src/main/java/org/eclipse/aether/util/ChecksumUtils.java b/maven-resolver-util/src/main/java/org/eclipse/aether/util/ChecksumUtils.java
index 00d6d91..0ac354f 100644
--- a/maven-resolver-util/src/main/java/org/eclipse/aether/util/ChecksumUtils.java
+++ b/maven-resolver-util/src/main/java/org/eclipse/aether/util/ChecksumUtils.java
@@ -168,6 +168,7 @@ public final class ChecksumUtils
* @param bytes The bytes to represent in hex notation, may be be {@code null}.
* @return The hexadecimal representation of the input or {@code null} if the input was {@code null}.
*/
+ @SuppressWarnings( "checkstyle:magicnumber" )
public static String toHexString( byte[] bytes )
{
if ( bytes == null )
diff --git a/maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/Stack.java b/maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/Stack.java
index 27fbb4b..5abdc5a 100644
--- a/maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/Stack.java
+++ b/maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/Stack.java
@@ -33,7 +33,9 @@ class Stack<E>
{
@SuppressWarnings( "unchecked" )
+ // CHECKSTYLE_OFF: MagicNumber
private E[] elements = (E[]) new Object[96];
+ // CHECKSTYLE_ON: MagicNumber
private int size;
diff --git a/maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/SecretAuthentication.java b/maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/SecretAuthentication.java
index 95a9471..57df653 100644
--- a/maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/SecretAuthentication.java
+++ b/maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/SecretAuthentication.java
@@ -81,6 +81,7 @@ final class SecretAuthentication
return ( chars != null ) ? chars.clone() : null;
}
+ @SuppressWarnings( "checkstyle:magicnumber" )
private char[] xor( char[] chars )
{
if ( chars != null )
diff --git a/maven-resolver-util/src/main/java/org/eclipse/aether/util/version/UnionVersionRange.java b/maven-resolver-util/src/main/java/org/eclipse/aether/util/version/UnionVersionRange.java
index b9fec1e..87ec190 100644
--- a/maven-resolver-util/src/main/java/org/eclipse/aether/util/version/UnionVersionRange.java
+++ b/maven-resolver-util/src/main/java/org/eclipse/aether/util/version/UnionVersionRange.java
@@ -157,6 +157,7 @@ final class UnionVersionRange
return ranges.equals( that.ranges );
}
+ @SuppressWarnings( "checkstyle:magicnumber" )
@Override
public int hashCode()
{
diff --git a/pom.xml b/pom.xml
index ff79ccd..c03bae0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -71,7 +71,7 @@
<javaVersion>7</javaVersion>
<surefire.redirectTestOutputToFile>true</surefire.redirectTestOutputToFile>
<maven.site.path>resolver-archives/resolver-LATEST</maven.site.path>
- <checkstyle.violation.ignore>MagicNumber,AvoidNestedBlocks</checkstyle.violation.ignore>
+ <checkstyle.violation.ignore>AvoidNestedBlocks</checkstyle.violation.ignore>
<sisuVersion>0.3.3</sisuVersion>
<slf4jVersion>1.7.25</slf4jVersion>
</properties>