[jira] Resolved: (WICKET-1984) MarkupContainer's add(final Component child) does not initially check for a child null reference

["Igor Vaynberg (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1984.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4-RC2

> MarkupContainer's add(final Component child) does not initially check for a child null reference 
> -------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1984
>                 URL: https://issues.apache.org/jira/browse/WICKET-1984
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.5
>            Reporter: James Perry
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.3.6, 1.4-RC2
>
>         Attachments: WICKET-1984.patch
>
>
> More specifically, the MarkupContainer's add(final Component child) calls checkHierarchyChange() before determining if the child reference is null. IMHO this should be ideally be called after checking if the child reference is null. From a user perspective, throwing an IllegalArgumentException with a message telling them that they have passed a null referenced component has better affordance then an esoteric NNE on calling checkHierarchyChange.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.