You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/04 06:08:31 UTC

[GitHub] [incubator-tvm] junrushao1994 opened a new pull request #5725: [Bugfix][Serialization] Fix runtime::String backward compatibility in JSON

junrushao1994 opened a new pull request #5725:
URL: https://github.com/apache/incubator-tvm/pull/5725


   @antinucleon sent me a JSON file which cannot be loaded in current HEAD on master. After bisecting around, I found that there are some missing parts (or just typos I think) in json_compact.py...
   
   Also CC: @tqchen @jwfromm @ANSHUMAN87 if you guys are interested


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5725: [Bugfix][Serialization] Fix runtime::String backward compatibility in JSON

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5725:
URL: https://github.com/apache/incubator-tvm/pull/5725#issuecomment-638925609


   Thansk @junrushao1994 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #5725: [Bugfix][Serialization] Fix runtime::String backward compatibility in JSON

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5725:
URL: https://github.com/apache/incubator-tvm/pull/5725


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] ANSHUMAN87 edited a comment on pull request #5725: [Bugfix][Serialization] Fix runtime::String backward compatibility in JSON

Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 edited a comment on pull request #5725:
URL: https://github.com/apache/incubator-tvm/pull/5725#issuecomment-638734857


   Thanks @junrushao1994 !
   As i remember, I had handled version upgrade for "GlobalVar" in PR (#5547).
   So maybe we need to discuss how it got bypassed?
   I saw the changes in jason_compact.py, just wonder why below code did not work:
   `"relay.GlobalVar": [_rename("GlobalVar"), _update_from_std_str("name_hint")],`
   
   I understand the issue is because of the key name difference "relay.Global" vs "Global".
   Please correct me if my understanding is wrong.
   
   I wonder whether json string is v0.6.0 based :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] ANSHUMAN87 commented on pull request #5725: [Bugfix][Serialization] Fix runtime::String backward compatibility in JSON

Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on pull request #5725:
URL: https://github.com/apache/incubator-tvm/pull/5725#issuecomment-638958232


   @junrushao1994 : Thanks a lot for clarifying! :+1: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] ANSHUMAN87 commented on pull request #5725: [Bugfix][Serialization] Fix runtime::String backward compatibility in JSON

Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on pull request #5725:
URL: https://github.com/apache/incubator-tvm/pull/5725#issuecomment-638734857


   Thanks @junrushao1994 !
   As i remember, I had handled version upgrade for "GlobalVar" in PR (#5547).
   So maybe we need to discuss how it got bypassed?
   I saw the changes in jason_compact.py, just wonder why below code did not work:
   `"relay.GlobalVar": [_rename("GlobalVar"), _update_from_std_str("name_hint")],`
   
   I understand the issue is because of the key name difference "relay.Global" vs "Global".
   Please correct me if my understanding is wrong.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5725: [Bugfix][Serialization] Fix runtime::String backward compatibility in JSON

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #5725:
URL: https://github.com/apache/incubator-tvm/pull/5725#issuecomment-638947410


   @ANSHUMAN87 yeah you are right. This is all about the type name.
   
   It is a bit tricky, because the JSON string was generated after 0.6.0 where type name is changed from relay.GlobalVar to GlobalVar, but before your PR #5547. This means that we still need to cover the case for GlobalVar :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org