You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/11/20 04:22:32 UTC

[GitHub] jiajiechen commented on issue #8684: [BugFix][CoreML Converter] Dense layers w/o bias.

jiajiechen commented on issue #8684: [BugFix][CoreML Converter] Dense layers w/o bias.
URL: https://github.com/apache/incubator-mxnet/pull/8684#issuecomment-345588252
 
 
   This looks good to me. 
   nitpick: I will suggest 
   ```python
   has_bias = not param.pop('no_bias', False)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services