You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by xt...@apache.org on 2026/01/27 13:08:54 UTC
(flink-agents) branch main updated (27d5385c -> 5be187b7)
This is an automated email from the ASF dual-hosted git repository.
xtsong pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/flink-agents.git
from 27d5385c [release] Auto updates documentation build ci when creating a new release branch (#495)
new 3eede02a [ollama] Align the behavior of think related parameters for ollama between python and java.
new 5be187b7 [doc] Update document for chat model.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
docs/content/docs/development/chat_models.md | 23 +++++++++++++---------
.../test/ChatModelIntegrationAgent.java | 1 +
.../flink/agents/examples/ReActAgentExample.java | 1 +
.../ollama/OllamaChatModelConnection.java | 14 +++++++++++--
.../chatmodels/ollama/OllamaChatModelSetup.java | 5 ++++-
5 files changed, 32 insertions(+), 12 deletions(-)
(flink-agents) 01/02: [ollama] Align the behavior of think related parameters for ollama between python and java.
Posted by xt...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
xtsong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-agents.git
commit 3eede02a788664f20fdc2540be20ab4eee5e2ad7
Author: WenjinXie <we...@gmail.com>
AuthorDate: Tue Jan 27 19:29:39 2026 +0800
[ollama] Align the behavior of think related parameters for ollama between python and java.
---
.../agents/integration/test/ChatModelIntegrationAgent.java | 1 +
.../apache/flink/agents/examples/ReActAgentExample.java | 1 +
.../chatmodels/ollama/OllamaChatModelConnection.java | 14 ++++++++++++--
.../chatmodels/ollama/OllamaChatModelSetup.java | 5 ++++-
4 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/e2e-test/flink-agents-end-to-end-tests-integration/src/test/java/org/apache/flink/agents/integration/test/ChatModelIntegrationAgent.java b/e2e-test/flink-agents-end-to-end-tests-integration/src/test/java/org/apache/flink/agents/integration/test/ChatModelIntegrationAgent.java
index 476afba3..99977169 100644
--- a/e2e-test/flink-agents-end-to-end-tests-integration/src/test/java/org/apache/flink/agents/integration/test/ChatModelIntegrationAgent.java
+++ b/e2e-test/flink-agents-end-to-end-tests-integration/src/test/java/org/apache/flink/agents/integration/test/ChatModelIntegrationAgent.java
@@ -104,6 +104,7 @@ public class ChatModelIntegrationAgent extends Agent {
return ResourceDescriptor.Builder.newBuilder(ResourceName.ChatModel.OLLAMA_SETUP)
.addInitialArgument("connection", "chatModelConnection")
.addInitialArgument("model", OLLAMA_MODEL)
+ .addInitialArgument("think", false)
.addInitialArgument(
"tools",
List.of("calculateBMI", "convertTemperature", "createRandomNumber"))
diff --git a/examples/src/main/java/org/apache/flink/agents/examples/ReActAgentExample.java b/examples/src/main/java/org/apache/flink/agents/examples/ReActAgentExample.java
index 4a68f6a7..624f3b83 100644
--- a/examples/src/main/java/org/apache/flink/agents/examples/ReActAgentExample.java
+++ b/examples/src/main/java/org/apache/flink/agents/examples/ReActAgentExample.java
@@ -147,6 +147,7 @@ public class ReActAgentExample {
ResourceDescriptor.Builder.newBuilder(ResourceName.ChatModel.OLLAMA_SETUP)
.addInitialArgument("connection", "ollamaChatModelConnection")
.addInitialArgument("model", "qwen3:8b")
+ .addInitialArgument("think", false)
.addInitialArgument(
"tools", Collections.singletonList("notifyShippingManager"))
.build(),
diff --git a/integrations/chat-models/ollama/src/main/java/org/apache/flink/agents/integrations/chatmodels/ollama/OllamaChatModelConnection.java b/integrations/chat-models/ollama/src/main/java/org/apache/flink/agents/integrations/chatmodels/ollama/OllamaChatModelConnection.java
index b591e0ea..773069f4 100644
--- a/integrations/chat-models/ollama/src/main/java/org/apache/flink/agents/integrations/chatmodels/ollama/OllamaChatModelConnection.java
+++ b/integrations/chat-models/ollama/src/main/java/org/apache/flink/agents/integrations/chatmodels/ollama/OllamaChatModelConnection.java
@@ -180,8 +180,18 @@ public class OllamaChatModelConnection extends BaseChatModelConnection {
public ChatMessage chat(
List<ChatMessage> messages, List<Tool> tools, Map<String, Object> arguments) {
try {
+ // convert think to think mode.
+ final Object think = arguments.getOrDefault("think", true);
+ ThinkMode thinkMode = ThinkMode.ENABLED;
+ for (ThinkMode mode : ThinkMode.values()) {
+ if (mode.getValue().equals(think)) {
+ thinkMode = mode;
+ break;
+ }
+ }
+
final boolean extractReasoning =
- (boolean) arguments.getOrDefault("extract_reasoning", false);
+ (boolean) arguments.getOrDefault("extract_reasoning", true);
final List<Tools.Tool> ollamaTools = this.convertToOllamaTools(tools);
final List<OllamaChatMessage> ollamaChatMessages =
@@ -194,7 +204,7 @@ public class OllamaChatModelConnection extends BaseChatModelConnection {
OllamaChatRequest.builder()
.withMessages(ollamaChatMessages)
.withModel(modelName)
- .withThinking(extractReasoning ? ThinkMode.ENABLED : ThinkMode.DISABLED)
+ .withThinking(thinkMode)
.withUseTools(false)
.build();
diff --git a/integrations/chat-models/ollama/src/main/java/org/apache/flink/agents/integrations/chatmodels/ollama/OllamaChatModelSetup.java b/integrations/chat-models/ollama/src/main/java/org/apache/flink/agents/integrations/chatmodels/ollama/OllamaChatModelSetup.java
index e12aed41..63805c81 100644
--- a/integrations/chat-models/ollama/src/main/java/org/apache/flink/agents/integrations/chatmodels/ollama/OllamaChatModelSetup.java
+++ b/integrations/chat-models/ollama/src/main/java/org/apache/flink/agents/integrations/chatmodels/ollama/OllamaChatModelSetup.java
@@ -56,13 +56,15 @@ import java.util.function.BiFunction;
public class OllamaChatModelSetup extends BaseChatModelSetup {
private final String model;
+ private final Object think;
private final boolean extractReasoning;
public OllamaChatModelSetup(
ResourceDescriptor descriptor, BiFunction<String, ResourceType, Resource> getResource) {
super(descriptor, getResource);
this.model = descriptor.getArgument("model");
- this.extractReasoning = descriptor.getArgument("extract_reasoning", false);
+ this.think = descriptor.getArgument("think", true);
+ this.extractReasoning = descriptor.getArgument("extract_reasoning", true);
}
/**
@@ -90,6 +92,7 @@ public class OllamaChatModelSetup extends BaseChatModelSetup {
public Map<String, Object> getParameters() {
Map<String, Object> params = new HashMap<>();
params.put("model", model);
+ params.put("think", think);
params.put("extract_reasoning", extractReasoning);
return params;
}
(flink-agents) 02/02: [doc] Update document for chat model.
Posted by xt...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
xtsong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-agents.git
commit 5be187b76d71d816241275ad44fb0fa3fc1c8348
Author: WenjinXie <we...@gmail.com>
AuthorDate: Tue Jan 27 19:31:02 2026 +0800
[doc] Update document for chat model.
---
docs/content/docs/development/chat_models.md | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/docs/content/docs/development/chat_models.md b/docs/content/docs/development/chat_models.md
index 739ccda3..7cecea68 100644
--- a/docs/content/docs/development/chat_models.md
+++ b/docs/content/docs/development/chat_models.md
@@ -427,19 +427,22 @@ Ollama provides local chat models that run on your machine, offering privacy, co
| `temperature` | float | `0.75` | Sampling temperature (0.0 to 1.0) |
| `num_ctx` | int | `2048` | Maximum number of context tokens |
| `keep_alive` | str \| float | `"5m"` | How long to keep model loaded in memory |
-| `extract_reasoning` | bool | `True` | Extract reasoning content from response |
-| `additional_kwargs` | dict | `{}` | Additional Ollama API parameters |
| `think` | bool \| Literal["low", "medium", "high"] | True | Whether enable model think |
+| `extract_reasoning` | bool | True | Extract reasoning content from response |
+| `additional_kwargs` | dict | `{}` | Additional Ollama API parameters |
{{< /tab >}}
{{< tab "Java" >}}
-| Parameter | Type | Default | Description |
-|-----------|------------------|---------|-------------|
-| `connection` | String | Required | Reference to connection method name |
-| `model` | String | Required | Name of the chat model to use |
-| `prompt` | Prompt \| String | None | Prompt template or reference to prompt resource |
-| `tools` | List[String] | None | List of tool names available to the model |
+| Parameter | Type | Default | Description |
+|---------------------|---------------------------------------------|----------|-------------------------------------------------|
+| `connection` | String | Required | Reference to connection method name |
+| `model` | String | Required | Name of the chat model to use |
+| `prompt` | Prompt \| String | None | Prompt template or reference to prompt resource |
+| `tools` | List[String] | None | List of tool names available to the model |
+| `think` | Boolean \| Literal["low", "medium", "high"] | true | Whether enable model think |
+| `extract_reasoning` | Boolean | true | Extract reasoning content from response |
+
{{< /tab >}}
{{< /tabs >}}
@@ -471,6 +474,7 @@ class MyAgent(Agent):
temperature=0.7,
num_ctx=4096,
keep_alive="10m",
+ think=True,
extract_reasoning=True
)
@@ -494,6 +498,7 @@ public class MyAgent extends Agent {
return ResourceDescriptor.Builder.newBuilder(ResourceName.ChatModel.OLLAMA_SETUP)
.addInitialArgument("connection", "ollamaConnection")
.addInitialArgument("model", "qwen3:8b")
+ .addInitialArgument("extract_reasoning", true)
.build();
}
@@ -831,7 +836,7 @@ class MyAgent(Agent):
@staticmethod
def tongyi_chat_model() -> ResourceDescriptor:
return ResourceDescriptor(
- clazz=ResourceName.ChatModel.Python.TONGYI_SETUP,
+ clazz=ResourceName.ChatModel.TONGYI_SETUP,
connection="tongyi_connection",
model="qwen-plus",
temperature=0.7,