You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/09/28 22:59:20 UTC
Review Request 68880: Cached the cgroup results in Docker
containerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68880/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, and Vinod Kone.
Repository: mesos
Description
-------
Since the cgroup hierarchy results won't change, it does not make sense
to compute it every time `usage` is called. It will get quite expensivie
when the host mount table is big (e.g., MESOS-8418).
This patch uses the static local variable to cache the result.
Diffs
-----
src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5
Diff: https://reviews.apache.org/r/68880/diff/1/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 68880: Cached the cgroup results in Docker
containerizer.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68880/#review209111
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Sept. 28, 2018, 4:09 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68880/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2018, 4:09 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-9279
> https://issues.apache.org/jira/browse/MESOS-9279
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the cgroup hierarchy results won't change, it does not make sense
> to compute it every time `usage` is called. It will get quite expensivie
> when the host mount table is big (e.g., MESOS-8418).
>
> This patch uses the static local variable to cache the result.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5
>
>
> Diff: https://reviews.apache.org/r/68880/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68880: Cached the cgroup results in Docker
containerizer.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68880/#review209112
-----------------------------------------------------------
PASS: Mesos patch 68880 was successfully built and tested.
Reviews applied: `['68880']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2405/mesos-review-68880
- Mesos Reviewbot Windows
On Sept. 28, 2018, 11:09 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68880/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2018, 11:09 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-9279
> https://issues.apache.org/jira/browse/MESOS-9279
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the cgroup hierarchy results won't change, it does not make sense
> to compute it every time `usage` is called. It will get quite expensivie
> when the host mount table is big (e.g., MESOS-8418).
>
> This patch uses the static local variable to cache the result.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5
>
>
> Diff: https://reviews.apache.org/r/68880/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68880: Cached the cgroup results in Docker
containerizer.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68880/
-----------------------------------------------------------
(Updated Sept. 28, 2018, 11:09 p.m.)
Review request for mesos, Gilbert Song, Greg Mann, and Vinod Kone.
Bugs: MESOS-9279
https://issues.apache.org/jira/browse/MESOS-9279
Repository: mesos
Description
-------
Since the cgroup hierarchy results won't change, it does not make sense
to compute it every time `usage` is called. It will get quite expensivie
when the host mount table is big (e.g., MESOS-8418).
This patch uses the static local variable to cache the result.
Diffs
-----
src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5
Diff: https://reviews.apache.org/r/68880/diff/1/
Testing
-------
sudo make check
Thanks,
Jie Yu