You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by ilooner <gi...@git.apache.org> on 2016/04/25 03:40:54 UTC
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2065 #resolve #comm...
GitHub user ilooner opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/255
APEXMALHAR-2065 #resolve #comment Added getWindowIds method to Window…
…Datamanager
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilooner/incubator-apex-malhar APEXMALHAR-2065
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/255.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #255
----
commit 1c47f658f9dbf5faccd966e85b5845b20fc90403
Author: Timothy Farkas <ti...@datatorrent.com>
Date: 2016-04-25T01:39:24Z
APEXMALHAR-2065 #resolve #comment Added getWindowIds method to WindowDatamanager
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2065 #resolve #comm...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/255#discussion_r60858878
--- Diff: library/src/main/java/org/apache/apex/malhar/lib/wal/WindowDataManager.java ---
@@ -227,6 +235,22 @@ public void delete(int operatorId, long windowId) throws IOException
return storageAgent.getWindowIds(operatorId);
}
+ @Override
+ public long[] getWindowIds() throws IOException
+ {
+ SortedSet<Long> windowIds = replayState.keySet();
+ long[] windowIdsArray = new long[windowIds.size()];
+
+ int index = 0;
+
+ for (Long windowId: windowIds) {
+ windowIdsArray[index] = windowId;
+ index++;
+ }
+
+ return windowIdsArray;
+ }
--- End diff --
Can you please document that windows ids are sorted?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2065 #resolve #comm...
Posted by ilooner <gi...@git.apache.org>.
Github user ilooner closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/255
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2065 #resolve #comm...
Posted by ilooner <gi...@git.apache.org>.
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/255#discussion_r60859142
--- Diff: library/src/main/java/org/apache/apex/malhar/lib/wal/WindowDataManager.java ---
@@ -227,6 +235,22 @@ public void delete(int operatorId, long windowId) throws IOException
return storageAgent.getWindowIds(operatorId);
}
+ @Override
+ public long[] getWindowIds() throws IOException
+ {
+ SortedSet<Long> windowIds = replayState.keySet();
+ long[] windowIdsArray = new long[windowIds.size()];
+
+ int index = 0;
+
+ for (Long windowId: windowIds) {
+ windowIdsArray[index] = windowId;
+ index++;
+ }
+
+ return windowIdsArray;
+ }
--- End diff --
@chandnisingh Added to the documentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---