You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/15 09:25:07 UTC
[GitHub] [cloudstack-primate] PaulAngus opened a new issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
PaulAngus opened a new issue #712:
URL: https://github.com/apache/cloudstack-primate/issues/712
**Describe the bug**
config.json property '@link-color' changes navigation section mouse-over color of links, but not the mouse-over colour in the details.
**To Reproduce**
Steps to reproduce the behavior; '@link-color' in the config.json file.
1. change the property
**Expected behavior**
The mouse-over colour in the details section changes to match the color set in the config.json file
**Screenshots**
**Additional context**
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #712:
URL: https://github.com/apache/cloudstack-primate/issues/712#issuecomment-692594475
@utchoang out of curiosity would it also be possible to add support for (a) general background colour (say for a black/dark theme) and (b) ensure that primary colour is used for popup notification loader (which floats when an action is performed such as stopping a VM, it shows a rotating circle in blue colour irrespective of primary colour)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #712:
URL: https://github.com/apache/cloudstack-primate/issues/712#issuecomment-696291620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland edited a comment on issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
Posted by GitBox <gi...@apache.org>.
DaanHoogland edited a comment on issue #712:
URL: https://github.com/apache/cloudstack-primate/issues/712#issuecomment-696291620
not sure if this is what @PaulAngus meant:
<img width="217" alt="image" src="https://user-images.githubusercontent.com/2486961/93806152-08487580-fc49-11ea-818f-1e1c29295de2.png">
the link color is changed as expected but the hovered link is still the default.
doh, never mind, it wasn't merged yet and i tested master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #712:
URL: https://github.com/apache/cloudstack-primate/issues/712#issuecomment-696291620
not sure if this is what @PaulAngus meant:
<img width="217" alt="image" src="https://user-images.githubusercontent.com/2486961/93806152-08487580-fc49-11ea-818f-1e1c29295de2.png">
the link color is changed as expected but the hovored link is still the default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #712:
URL: https://github.com/apache/cloudstack-primate/issues/712#issuecomment-696335533
tests ok in pr #718
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #712:
URL: https://github.com/apache/cloudstack-primate/issues/712#issuecomment-692592154
Hi @utchoang since you had added support for theming in Primate, can you look into adding support for link:hover or make it use the configured link-color when mouse is hovered on links. cc @svenvogel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland edited a comment on issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
Posted by GitBox <gi...@apache.org>.
DaanHoogland edited a comment on issue #712:
URL: https://github.com/apache/cloudstack-primate/issues/712#issuecomment-696291620
not sure if this is what @PaulAngus meant:
<img width="217" alt="image" src="https://user-images.githubusercontent.com/2486961/93806152-08487580-fc49-11ea-818f-1e1c29295de2.png">
the link color is changed as expected but the hovered link is still the default.
doh, never mind, it wasn't merged yet and i tested master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #712:
URL: https://github.com/apache/cloudstack-primate/issues/712#issuecomment-697151077
LGTM, verified link and hover colour
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #712:
URL: https://github.com/apache/cloudstack-primate/issues/712#issuecomment-697232644
Vefied and close in PR #718
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #712:
URL: https://github.com/apache/cloudstack-primate/issues/712#issuecomment-692599930
@rhtyd I think this is doable. I will try it out and notify you later. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #712:
URL: https://github.com/apache/cloudstack-primate/issues/712
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org