You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Aidan Skinner <ai...@gmail.com> on 2009/08/09 23:09:47 UTC

Re: [RFC] [Java] QPID-2018 Clear queue doesn't clear acquired messages which is a little confusing if that's all there is.

On Sun, Aug 9, 2009 at 9:41 PM, Robbie Gemmell<ro...@gmail.com> wrote:

> Checks for undeleted messages could be made using this number along with the before/after MessageCount, but of course general queue activity during the process could cause such a check to reach the wrong conclusion. In order to accurately report the number of messages not deleted due to being in an acquired state a new 'clearQueueAndReportNumAcquired' method would need to be added to (Simple)AMQQueue, does that seem ok to everyone? The only real alternative is to start using the return value of the existing method in the MBean and have the console indicate how many messages were deleted, rather than how many were not. Thoughts?

Reporting how many were deleted seems reasonable to me, I don't see
much gain in introducing a new method to do something slightly
different.

- Aidan

-- 
Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org
"A witty saying proves nothing" - Voltaire

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Re: [RFC] [Java] QPID-2018 Clear queue doesn't clear acquired messages which is a little confusing if that's all there is.

Posted by Aidan Skinner <ai...@gmail.com>.
On Sun, Aug 9, 2009 at 10:27 PM, Robbie Gemmell<ro...@gmail.com> wrote:

> That was my thinking too. Id have just done that, but since it is the
> opposite of your original suggestion I thought id ask first :)

I'd like to think I would have suggested this if I'd read the relevant
code first. ;)

- Aidan (who would also like a pony, and a puppy and..)

-- 
Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org
"A witty saying proves nothing" - Voltaire

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


RE: [RFC] [Java] QPID-2018 Clear queue doesn't clear acquired messages which is a little confusing if that's all there is.

Posted by Robbie Gemmell <ro...@gmail.com>.
That was my thinking too. Id have just done that, but since it is the
opposite of your original suggestion I thought id ask first :)

Robbie

> -----Original Message-----
> From: Aidan Skinner [mailto:aidan.skinner@gmail.com]
> Sent: 09 August 2009 22:10
> To: dev@qpid.apache.org
> Subject: Re: [RFC] [Java] QPID-2018 Clear queue doesn't clear acquired
> messages which is a little confusing if that's all there is.
> 
> On Sun, Aug 9, 2009 at 9:41 PM, Robbie
> Gemmell<ro...@gmail.com> wrote:
> 
> > Checks for undeleted messages could be made using this number along
> with the before/after MessageCount, but of course general queue
> activity during the process could cause such a check to reach the wrong
> conclusion. In order to accurately report the number of messages not
> deleted due to being in an acquired state a new
> 'clearQueueAndReportNumAcquired' method would need to be added to
> (Simple)AMQQueue, does that seem ok to everyone? The only real
> alternative is to start using the return value of the existing method
> in the MBean and have the console indicate how many messages were
> deleted, rather than how many were not. Thoughts?
> 
> Reporting how many were deleted seems reasonable to me, I don't see
> much gain in introducing a new method to do something slightly
> different.
> 
> - Aidan
> 
> --
> Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org
> "A witty saying proves nothing" - Voltaire
> 
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project:      http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org