Re: [PR] [SPARK-49854][SQL] Clone artifact manager during session clone [spark]

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #48320:
URL: https://github.com/apache/spark/pull/48320#discussion_r1792401395


##########
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala:
##########
@@ -106,7 +106,14 @@ private[sql] class SessionState(
   // when connecting to ThriftServer.
   lazy val streamingQueryManager: StreamingQueryManager = streamingQueryManagerBuilder()
 
-  lazy val artifactManager: ArtifactManager = artifactManagerBuilder()
+  private[sql] var _artifactManager: Option[ArtifactManager] = None
+
+  def artifactManager: ArtifactManager = {

Review Comment:
   Why is this a def? We should only create the manager once right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org