[GitHub] kl0u commented on issue #7850: [FLINK-11183][metrics] Properly measure current memory usage

[GitBox <gi...@apache.org>]

kl0u commented on issue #7850: [FLINK-11183][metrics] Properly measure current memory usage
URL: https://github.com/apache/flink/pull/7850#issuecomment-468667916
 
 
   Shouldn't there be a test to check that this works and to guarantee that it will continue working in the future?
   
   If I understand the JIRA correctly, the problem was that the reported metric was never updated. If measuring memory is not easy to test (because it depends on what runs on the machine at any point in time), at least we can measure once, allocate a big object, and then measure again and see that the two measurements differ. Of course, sth more accurate would be even better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services