You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@olingo.apache.org by Giacomo Pati <gi...@pati.ch> on 2014/10/31 08:41:08 UTC

Serious bug in FilterParser

Hi all

We recently run into a serious issue regarding filters and I want someone
of you to double check. When you run the following query against a
deployed olingo-odata2-jpa-processor-ref-web
like

http://localhost:8080/SalesOrderProcessing.svc/SalesOrderItems?$filter=(SoId
eq 2 or SoId eq 3 or SoId eq 4) and Delivered eq true

one would expect to see only Entities with a property Delivered == true but
this is not the case. I've also run a quick junit test against
FilterParserImpl with such a query using an ExpressionVisitor and figured
that it seems that the parenthesis are not respected which would reduce the
query to "SoId eq 2 or SoId eq 3 or SoId eq 4 and Delivered eq true" and it
seems that is actually what happens.

Anyone else?

Ciao
-- 
Giacomo

Re: Serious bug in FilterParser

Posted by "Bolz, Michael" <mi...@sap.com>.
Hi all,

@Sven: Can you take a look into this [as expert for FilterParser  ;o)].

Kind regards,
Michael

On 31/10/14 08:41, "Giacomo Pati" <gi...@pati.ch> wrote:

>Hi all
>
>We recently run into a serious issue regarding filters and I want someone
>of you to double check. When you run the following query against a
>deployed olingo-odata2-jpa-processor-ref-web
>like
>
>http://localhost:8080/SalesOrderProcessing.svc/SalesOrderItems?$filter=(So
>Id
>eq 2 or SoId eq 3 or SoId eq 4) and Delivered eq true
>
>one would expect to see only Entities with a property Delivered == true
>but
>this is not the case. I've also run a quick junit test against
>FilterParserImpl with such a query using an ExpressionVisitor and figured
>that it seems that the parenthesis are not respected which would reduce
>the
>query to "SoId eq 2 or SoId eq 3 or SoId eq 4 and Delivered eq true" and
>it
>seems that is actually what happens.
>
>Anyone else?
>
>Ciao
>-- 
>Giacomo