You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "michalvavrik (via GitHub)" <gi...@apache.org> on 2025/09/07 20:35:30 UTC
[PR] feat(api): Add Integration Git Branch, Commit and Tag options [camel-k]
michalvavrik opened a new pull request, #6269:
URL: https://github.com/apache/camel-k/pull/6269
- closes: #6135
Changes:
- make the project cloning for the default branch shallow (depth 1 commit)
- add option to checkout Git tag and test it
- add option to checkout Git branch and test it
- add option to checkout Git commit and test it (this is the least efficient of the 3 as it requires the full project history checkout)
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(api): Add Integration Git Branch, Commit and Tag options [camel-k]
Posted by "michalvavrik (via GitHub)" <gi...@apache.org>.
michalvavrik commented on PR #6269:
URL: https://github.com/apache/camel-k/pull/6269#issuecomment-3266139719
Should be fixed, the `make lint` command is now passing for me. When I resolved git auth config issue, I kept getting:
```
mvavrik@fedora:~/sources/camel-k$ make lint
GOBIN=/home/mvavrik/sources/camel-k/bin go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.5
go: downloading github.com/tdakkota/asciicheck v0.4.0
../../go/pkg/mod/github.com/golangci/golangci-lint@v1.64.5/pkg/golinters/asciicheck/asciicheck.go:4:2: reading github.com/tdakkota/asciicheck/go.mod at revision v0.4.0: git ls-remote -q origin in /home/mvavrik/go/pkg/mod/cache/vcs/e91413ff76cb95901df8e2d834855d07c617befa58b5014bc6cd6fd1148034dd: exit status 128:
ERROR: Repository not found.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
make: *** [Makefile:742: golangci-lint] Error 1
```
so I had to resolve to:
```
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b /home/mvavrik/sources/camel-k/bin v1.64.5
```
and dropping `GOBIN=$(LOCALBIN) go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(LINTER_VERSION)`.
At least now I have a motivation to look into https://github.com/apache/camel-k/issues/6122 so that I understand my issue better, it is most likely in my setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(api): Add Integration Git Branch, Commit and Tag options [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #6269:
URL: https://github.com/apache/camel-k/pull/6269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(api): Add Integration Git Branch, Commit and Tag options [camel-k]
Posted by "michalvavrik (via GitHub)" <gi...@apache.org>.
michalvavrik commented on PR #6269:
URL: https://github.com/apache/camel-k/pull/6269#issuecomment-3265787337
Sorry I didn't catch the validation failure, I tried to run the validation before but it failed for me:
```
mvavrik@fedora:~/sources/camel-k$ make lint
GOBIN=/home/mvavrik/sources/camel-k/bin go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.5
go: downloading github.com/tdakkota/asciicheck v0.4.0
../../go/pkg/mod/github.com/golangci/golangci-lint@v1.64.5/pkg/golinters/asciicheck/asciicheck.go:4:2: reading github.com/tdakkota/asciicheck/go.mod at revision v0.4.0: git ls-remote -q origin in /home/mvavrik/go/pkg/mod/cache/vcs/e91413ff76cb95901df8e2d834855d07c617befa58b5014bc6cd6fd1148034dd: exit status 128:
/usr/bin/gh auth git-credential get: line 1: /usr/bin/gh: No such file or directory
fatal: could not read Username for 'https://github.com': terminal prompts disabled
Confirm the import path was entered correctly.
If this is a private repository, see https://golang.org/doc/faq#git_https for additional information.
make: *** [Makefile:742: golangci-lint] Error 1
```
I'll rewrite the if-else to the switch statement and look what the GH CI does when running validation so that I can check it prior pushing commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(api): Add Integration Git Branch, Commit and Tag options [camel-k]
Posted by "michalvavrik (via GitHub)" <gi...@apache.org>.
michalvavrik commented on PR #6269:
URL: https://github.com/apache/camel-k/pull/6269#issuecomment-3265822266
Right, I missed this part https://github.com/apache/camel-k/blob/main/docs/modules/ROOT/pages/contributing/developers.adoc#running-checks, my bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org