You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airavata.apache.org by ya...@apache.org on 2026/03/30 12:41:42 UTC

(airavata) 07/16: refactor: un-deprecate addRoleToUser, removeRoleFromUser, getUsersWithRole

This is an automated email from the ASF dual-hosted git repository.

yasith pushed a commit to branch worktree-cleanup+lean-core
in repository https://gitbox.apache.org/repos/asf/airavata.git

commit 7f236f095a3e9800ba8e9c82628c269b75156334
Author: yasithdev <ya...@icloud.com>
AuthorDate: Mon Mar 30 07:44:41 2026 -0400

    refactor: un-deprecate addRoleToUser, removeRoleFromUser, getUsersWithRole
    
    All three methods are defined in the Thrift IDL (iam-admin-services-cpi.thrift)
    and cannot be removed. Remove spurious @Deprecated annotations from
    IamAdminServicesHandler and TenantManagementInterface.
    
    Co-Authored-By: Claude Sonnet 4.6 <no...@anthropic.com>
---
 .../iam/admin/services/core/interfaces/TenantManagementInterface.java  | 3 ---
 .../apache/airavata/server/thrift/handler/IamAdminServicesHandler.java | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/airavata-api/src/main/java/org/apache/airavata/security/profile/iam/admin/services/core/interfaces/TenantManagementInterface.java b/airavata-api/src/main/java/org/apache/airavata/security/profile/iam/admin/services/core/interfaces/TenantManagementInterface.java
index b6f3b49488..2eab816e18 100644
--- a/airavata-api/src/main/java/org/apache/airavata/security/profile/iam/admin/services/core/interfaces/TenantManagementInterface.java
+++ b/airavata-api/src/main/java/org/apache/airavata/security/profile/iam/admin/services/core/interfaces/TenantManagementInterface.java
@@ -199,7 +199,6 @@ public interface TenantManagementInterface {
      * @return
      * @throws IamAdminServicesException
      */
-    @Deprecated
     boolean addRoleToUser(PasswordCredential realmAdminCreds, String tenantId, String username, String roleName)
             throws IamAdminServicesException;
 
@@ -213,7 +212,6 @@ public interface TenantManagementInterface {
      * @return
      * @throws IamAdminServicesException
      */
-    @Deprecated
     boolean removeRoleFromUser(PasswordCredential realmAdminCreds, String tenantId, String username, String roleName)
             throws IamAdminServicesException;
 
@@ -226,7 +224,6 @@ public interface TenantManagementInterface {
      * @return
      * @throws IamAdminServicesException
      */
-    @Deprecated
     List<UserProfile> getUsersWithRole(PasswordCredential realmAdminCreds, String tenantId, String roleName)
             throws IamAdminServicesException;
 }
diff --git a/airavata-server/thrift/src/main/java/org/apache/airavata/server/thrift/handler/IamAdminServicesHandler.java b/airavata-server/thrift/src/main/java/org/apache/airavata/server/thrift/handler/IamAdminServicesHandler.java
index 0fc7d2a7a5..69cbd926c2 100644
--- a/airavata-server/thrift/src/main/java/org/apache/airavata/server/thrift/handler/IamAdminServicesHandler.java
+++ b/airavata-server/thrift/src/main/java/org/apache/airavata/server/thrift/handler/IamAdminServicesHandler.java
@@ -275,7 +275,6 @@ public class IamAdminServicesHandler implements IamAdminServices.Iface {
 
     @Override
     @SecurityCheck
-    @Deprecated
     public boolean addRoleToUser(AuthzToken authzToken, String username, String roleName)
             throws IamAdminServicesException, AuthorizationException, TException {
         TenantManagementKeycloakImpl keycloakclient = new TenantManagementKeycloakImpl();
@@ -292,7 +291,6 @@ public class IamAdminServicesHandler implements IamAdminServices.Iface {
 
     @Override
     @SecurityCheck
-    @Deprecated
     public boolean removeRoleFromUser(AuthzToken authzToken, String username, String roleName)
             throws IamAdminServicesException, AuthorizationException, TException {
         TenantManagementKeycloakImpl keycloakclient = new TenantManagementKeycloakImpl();
@@ -309,7 +307,6 @@ public class IamAdminServicesHandler implements IamAdminServices.Iface {
 
     @Override
     @SecurityCheck
-    @Deprecated
     public List<UserProfile> getUsersWithRole(AuthzToken authzToken, String roleName)
             throws IamAdminServicesException, AuthorizationException, TException {