Re: The etiquette of pocking people on Github and the policy when people stop responding

[Jonathan Wei <jo...@apache.org>]

I think poking preferences are a fairly personal/subjective thing, and I
don't think we need a general formalized policy presently given the size of
our committer pool. I don't mind being poked often, for example.

I think it's enough to have an informal social understanding amongst the
committers for now ("this committer prefers to be poked less frequently,
let's keep that in mind").

For the case where a PR has enough approvals for merge but an incomplete
review from another committer, I think it's good to give that committer
some time to complete their review, but I would suggest a period of a 3-4
days; two weeks seems too long to me.

Thanks,
Jon


On Wed, Jan 30, 2019 at 5:22 AM Roman Leventov <le...@gmail.com>
wrote:

> On Tue, 29 Jan 2019 at 01:30, Fangjin Yang <fa...@imply.io> wrote:
>
> > I disagree with Roman's suggestions. If a PR has enough votes, we should
> > trust the committers approving the PR and move forward.
> >
>
> There is a specific committer who merges a PR. If this happens while it's
> not made clear that somebody who left comments before doesn't have any more
> comments, the whole situation looks to me more like disregard of that
> person's opinion. The trust to other committers doesn't help to make the
> situation look much better, IMO.
>