[jira] [Commented] (REEF-2059) Upgrade netty from 4.0 to 4.1

["Sergiy Matusevych (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039766#comment-17039766 ] 

Sergiy Matusevych commented on REEF-2059:
-----------------------------------------

Fixed in the same [github pull request #1496|https://github.com/apache/reef/pull/1496]

> Upgrade netty from 4.0 to 4.1
> -----------------------------
>
>                 Key: REEF-2059
>                 URL: https://issues.apache.org/jira/browse/REEF-2059
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF Bridge, Wake
>         Environment: Reproducible on Ubuntu 19.10 with OpenJDK-8 and Netty 4.1.42.Final
> Fork from [https://github.com/motus/reef/tree/REEF-2057] to get the updated code (with unit tests failing)
>            Reporter: Sergiy Matusevych
>            Priority: Major
>
> We need to update REEF dependencies to be in sync with Hadoop, Spark, and our own REEF gRPC bridge. For that, we have to upgrade Netty from 4.0.23.Final used in Wake, to 4.1.42.Final. Using the new version (or any other Netty 4.1) causes unit test failures in Wake. Two tests fail with Netty 4.1:
> {code}
> org.apache.reef.wake.test.remote.RemoteManagerTest.testRemoteManagerConnectionRetryTest:137 expected:<2> but was:<0>
> org.apache.reef.wake.test.remote. RemoteManagerTest.testRemoteManagerConnectionRetryWithMultipleSenderTest:171 expected:<10> but was:<0>
>  {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)